[GitHub] [netbeans] mbien commented on pull request #4502: #4500 static imported methods slow down auto completion

[GitBox <gi...@apache.org>]

mbien commented on PR #4502:
URL: https://github.com/apache/netbeans/pull/4502#issuecomment-1214347659

   hi @matthiasblaesing @tonihele,
   
   thanks for the reviews/comments. Here some of my thoughts why I made this target NB 15 during rc phase and why I haven't tried anything beyond breaking up quadratic complexity (its connected):
   
   - easily avoidable quadratic complexity is a performance defect IMO, which should be seen the same as a bug. Since this could be reduced to linear so easily after finding what it is, its also easy reviewable and a candidate for inclusion in NB 15 IMO.
   - completion for the synthetic test of 10k fields and methods improved from unusable to instantly already with this fix
   - building HahsMaps/Sets takes time too, so this would need more measurements and I wanted to propose this PR quickly and it had to be simple as possible.
   - anything more difficult to review should be targeted for NB 16, with measurements showing that it is worth building a hashmap (anyone is welcome to do that)
   
   so if anyone is reviewing this: please concentrate on correctness. Further improvements would be for 16.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists