You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2017/12/06 04:21:52 UTC

[GitHub] incubator-weex pull request #931: [WEEX-162][android] When Cell Position Cha...

GitHub user gubaojian opened a pull request:

    https://github.com/apache/incubator-weex/pull/931

    [WEEX-162][android] When Cell Position Changed , outOfVisibleRange not right

    When Cell Position Changed , outOfVisibleRange not accurate, item.getCellPositionINScollable() get wrong position use instead.
    boolean outOfVisibleRange = !ViewCompat.isAttachedToWindow(view);


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gubaojian/incubator-weex release-0.17-cell-position-not-right

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #931
    
----
commit ed65633cd503c820b9a31f0651c1f42f4e705e7e
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date:   2017-12-06T04:20:32Z

    [WEEX-162][android] When Cell Position Changed , outOfVisibleRange not accurate, item.getCellPositionINScollable() get wrong position, use attachWindow instead

----


---

[GitHub] incubator-weex pull request #931: [WEEX-162][android] When Cell Position Cha...

Posted by gubaojian <gi...@git.apache.org>.

Github user gubaojian closed the pull request at:

    https://github.com/apache/incubator-weex/pull/931


---

[GitHub] incubator-weex pull request #931: [WEEX-162][android] When Cell Position Cha...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/931


---

[GitHub] incubator-weex pull request #931: [WEEX-162][android] When Cell Position Cha...

Posted by gubaojian <gi...@git.apache.org>.

GitHub user gubaojian reopened a pull request:

    https://github.com/apache/incubator-weex/pull/931

    [WEEX-162][android] When Cell Position Changed , item.getCellPositionINScollable() not right

    When Cell Position Changed , outOfVisibleRange not accurate, item.getCellPositionINScollable() get wrong position use instead.
    boolean outOfVisibleRange = !ViewCompat.isAttachedToWindow(view);


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gubaojian/incubator-weex release-0.17-cell-position-not-right

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #931
    
----
commit ed65633cd503c820b9a31f0651c1f42f4e705e7e
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date:   2017-12-06T04:20:32Z

    [WEEX-162][android] When Cell Position Changed , outOfVisibleRange not accurate, item.getCellPositionINScollable() get wrong position, use attachWindow instead

----


---

[GitHub] incubator-weex issue #931: [WEEX-162][android] When Cell Position Changed , ...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/931
  
    
    <!--
      0 failure: 
      2 warning:  No Changelog chan..., This PR should up...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---