You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/08 10:17:05 UTC
[GitHub] [incubator-shenyu] KevinClair opened a new pull request, #3500: [type: refactor] Refactor http long polling.
KevinClair opened a new pull request, #3500:
URL: https://github.com/apache/incubator-shenyu/pull/3500
<!-- Describe your PR here; eg. Fixes #issueNo -->
In the past, http long polling is to request the server to obtain the token by `each http long polling`
Modify it to periodically request the server to refresh the token, and modify it to the latest token in the refresh window.
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3500: [type: refactor] Refactor http long polling.
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3500:
URL: https://github.com/apache/incubator-shenyu/pull/3500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3500: [type: refactor] Refactor http long polling.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3500:
URL: https://github.com/apache/incubator-shenyu/pull/3500#issuecomment-1149751308
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3500](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39f25fb) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/f53e81170f2ad0a71ace6f7e62cc54d70c8fcb4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f53e811) will **decrease** coverage by `0.36%`.
> The diff coverage is `81.08%`.
```diff
@@ Coverage Diff @@
## master #3500 +/- ##
============================================
- Coverage 62.94% 62.58% -0.37%
+ Complexity 5564 5533 -31
============================================
Files 840 841 +1
Lines 23256 23279 +23
Branches 2109 2108 -1
============================================
- Hits 14638 14568 -70
- Misses 7271 7361 +90
- Partials 1347 1350 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/shenyu/common/constant/Constants.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `70.58% <ø> (ø)` | |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `82.75% <ø> (-0.58%)` | :arrow_down: |
| [...ache/shenyu/sync/data/http/AccessTokenManager.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvQWNjZXNzVG9rZW5NYW5hZ2VyLmphdmE=) | `72.22% <72.22%> (ø)` | |
| [...rter/sync/data/http/HttpSyncDataConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItc3luYy1kYXRhLWNlbnRlci9zaGVueXUtc3ByaW5nLWJvb3Qtc3RhcnRlci1zeW5jLWRhdGEtaHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3NwcmluZ2Jvb3Qvc3RhcnRlci9zeW5jL2RhdGEvaHR0cC9IdHRwU3luY0RhdGFDb25maWd1cmF0aW9uLmphdmE=) | `81.25% <78.57%> (-18.75%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `85.71% <93.33%> (+1.97%)` | :arrow_up: |
| [...he/shenyu/admin/model/vo/LoginDashboardUserVO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvdm8vTG9naW5EYXNoYm9hcmRVc2VyVk8uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...u/admin/service/impl/DashboardUserServiceImpl.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0Rhc2hib2FyZFVzZXJTZXJ2aWNlSW1wbC5qYXZh) | `86.02% <100.00%> (ø)` | |
| [...nyu/sync/data/http/refresh/AppAuthDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BcHBBdXRoRGF0YVJlZnJlc2guamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...shenyu/sync/data/http/refresh/MetaDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9NZXRhRGF0YVJlZnJlc2guamF2YQ==) | `100.00% <100.00%> (ø)` | |
| ... and [41 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3500/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f53e811...39f25fb](https://codecov.io/gh/apache/incubator-shenyu/pull/3500?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] zhc00 commented on pull request #3500: [type: refactor] Refactor http long polling.
Posted by GitBox <gi...@apache.org>.
zhc00 commented on PR #3500:
URL: https://github.com/apache/incubator-shenyu/pull/3500#issuecomment-1149768042
Please hold down a second. Let #3501 merge first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org