You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/25 22:24:50 UTC

[GitHub] [beam] pabloem commented on pull request #12855: Update BigQueryAvroUtils.java to properly support BOOL type of Big Query

pabloem commented on pull request #12855:
URL: https://github.com/apache/beam/pull/12855#issuecomment-699186422


   Thanks @xasm83 - we appreciate your contribution! 
   
   We have a test that expects the wrong type name: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/13598/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQueryAvroUtilsTest/testConvertGenericRecordToTableRow/
   
   Could you allow "BOOL" and "BOOLEAN" types in your change, in case we rely on the wrong time somewhere? And please change the test in BigQueryAvroUtilsTest?
   
   Thanks again!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org