You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/04 00:05:53 UTC

[GitHub] feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI

feng-tao commented on a change in pull request #4425: [AIRFLOW-3623] Support download logs by attempts from UI
URL: https://github.com/apache/incubator-airflow/pull/4425#discussion_r245168256
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -770,7 +774,12 @@ def get_logs_with_metadata(self, session=None):
         task_id = request.args.get('task_id')
         execution_date = request.args.get('execution_date')
         dttm = pendulum.parse(execution_date)
-        try_number = int(request.args.get('try_number'))
+        if request.args.get('try_number', None) is not None:
 
 Review comment:
   small nit: request.args.get('try_number', None) could be request.args.get('try_number') as the default should be None

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services