[jira] [Commented] (DRILL-5316) C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898612#comment-15898612 ] 

ASF GitHub Bot commented on DRILL-5316:
---------------------------------------

GitHub user superbstreak opened a pull request:

    https://github.com/apache/drill/pull/772

    DRILL-5316: Check drillbitsVector count from zoo_get_children before …

    …we attempt to access the vector element

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/superbstreak/drill DRILL-5316

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #772
    
----
commit c9ca5a35aa684992d58d93e50a7a9ff7ce16ead8
Author: Rob Wu <ro...@gmail.com>
Date:   2017-03-07T02:17:25Z

    DRILL-5316: Check drillbitsVector count from zoo_get_children before we attempt to access the vector element

----


> C++ Client Crashes When drillbitsVector.count is 0 after zoo_get_children completed with ZOK
> --------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5316
>                 URL: https://issues.apache.org/jira/browse/DRILL-5316
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>            Reporter: Rob Wu
>            Priority: Critical
>
> When connecting to drillbit with Zookeeper, occasionally the C++ client would crash without any reason.
> A further look into the code revealed that during this call 
> rc=zoo_get_children(p_zh.get(), m_path.c_str(), 0, &drillbitsVector); 
> zoo_get_children returns ZOK (0) but drillbitsVector.count is 0.
> This causes drillbits to stay empty and thus 
> causes err = zook.getEndPoint(drillbits[drillbits.size() -1], endpoint); to crash
> Size check should be done to prevent this from happening



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)