You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Goooler (via GitHub)" <gi...@apache.org> on 2024/02/04 02:35:41 UTC
[PR] Remove redundant `gradle_version` property [groovy]
Goooler opened a new pull request, #2050:
URL: https://github.com/apache/groovy/pull/2050
It's easy to forget to modify this property, and we have no much necessary to input it for Wrapper tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925609969
If we can remove that line to prevent `gradle/wrapper` been deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925559975
## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d547089`)](https://app.codecov.io/gh/apache/groovy/commit/d5470899c4e7706dc54863d020e7792d4c71db76?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5316% compared to head [(`18a66e3`)](https://app.codecov.io/gh/apache/groovy/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5219%.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2050 +/- ##
==================================================
- Coverage 68.5316% 68.5219% -0.0097%
+ Complexity 29174 29170 -4
==================================================
Files 1422 1422
Lines 113482 113482
Branches 19548 19548
==================================================
- Hits 77771 77760 -11
- Misses 29174 29181 +7
- Partials 6537 6541 +4
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2050/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "aalmiray (via GitHub)" <gi...@apache.org>.
aalmiray commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925654703
FWIW I followed the trail of the Maven wrapper to bootstrap it from source. The initial commit is here https://github.com/jreleaser/jreleaser/commit/82f0706d98674f761d7253b81952b19756100ada with updates posted a few times later. In case you'd like to do something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925604789
I don't think we can remove this. Current ASF policy prohibits binary files like the wrapper jar from being included in the src zip. So, to build from source, we need to have the bootstrap step. Here is where we exclude 'wrapper' (which contains version in properties file):
https://github.com/apache/groovy/blob/master/subprojects/groovy-binary/build.gradle#L184
Best bet is to only update version using bootstrap step - though I realise that isn't what dependabot et al will use or the standard instructions from Gradle.
There are other approaches to solve the problem, which I guess we could relook at, but it wouldn't be (just) the change suggested here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925641963
That is the spec for building the source zip. As per ASF requirements, it can't contain binary files, e.g. gradle-wrapper.jar. We have asked for an exemption in the past but haven't been successful. ASF values highly the "openness" of the source zip. The implication is that anyone should be able to look at the files used within the source zip when building from source and understand what everything does without having to try to work out what might be inside any binary object such as a jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler closed pull request #2050: Remove redundant `gradle_version` property
URL: https://github.com/apache/groovy/pull/2050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant `gradle_version` property [groovy]
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler commented on PR #2050:
URL: https://github.com/apache/groovy/pull/2050#issuecomment-1925642357
Got it! Thanks for your explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org