You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/20 12:08:08 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7355:
[security] New, deprecate merge_perm, FAB method is fixed
codecov-io edited a comment on issue #7355: [security] New, deprecate merge_perm, FAB method is fixed
URL: https://github.com/apache/incubator-superset/pull/7355#issuecomment-485882808
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=h1) Report
> Merging [#7355](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/845218dd88ad2fe1284dcb7427c5bff20749dc74?src=pr&el=desc) will **increase** coverage by `8.44%`.
> The diff coverage is `35.29%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7355/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7355 +/- ##
==========================================
+ Coverage 64.89% 73.34% +8.44%
==========================================
Files 428 84 -344
Lines 20937 11121 -9816
Branches 2330 0 -2330
==========================================
- Hits 13588 8157 -5431
+ Misses 7225 2964 -4261
+ Partials 124 0 -124
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.01% <ø> (+0.95%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `63.15% <0%> (ø)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `66.21% <0%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.92% <100%> (+0.02%)` | :arrow_up: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `74.77% <66.66%> (-1.42%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `86.95% <0%> (-7.69%)` | :arrow_down: |
| [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | `58.03% <0%> (-1.06%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.38% <0%> (-0.13%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.46% <0%> (-0.11%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.15% <0%> (-0.08%)` | :arrow_down: |
| ... and [365 more](https://codecov.io/gh/apache/incubator-superset/pull/7355/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=footer). Last update [845218d...65e231c](https://codecov.io/gh/apache/incubator-superset/pull/7355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org