You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "yl09099 (via GitHub)" <gi...@apache.org> on 2023/07/19 14:55:26 UTC

[GitHub] [incubator-uniffle] yl09099 opened a new pull request, #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

yl09099 opened a new pull request, #963:
URL: https://github.com/apache/incubator-uniffle/pull/963

   ### What changes were proposed in this pull request?
   
   Uniffle does not have a webUI interface for viewing parameters and absorbing relationships, so it needs a more intuitive display
   
   ### Why are the changes needed?
   
   Fix: #960
   
   ### Does this PR introduce _any_ user-facing change?
   
   Added a webUI interface to change the API access to Jersey
   
   ### How was this patch tested?
   
   Add Some UnitTest
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on pull request #963: [#960][Feature] Uniffle needs to add a WebUI page

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1605918055

   This is really nice, remind me of the old good web ui for baidu's DCE shuffle.
   I will review this later today. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1647746610

   This is a large PR. do you think it's possible to split this pr into various parts:
   1. modification to the REST API
   2. the dashboard module + backend stuff
   3. the web ui part and various utility stuff, such as the start and stop scripts.
   
   In that way, I think we can speed up the review and merge process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960][Improvement] Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1604147451

   5. For the information to be displayed on the page, you are welcome to make suggestions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#discussion_r1270186376


##########
dashboard/src/main/webapp/jsconfig.json:
##########
@@ -0,0 +1,19 @@
+{

Review Comment:
   Every file must have Apache license.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1644939799

   > 
   
   The new icon is already being designed, I will modify it next time


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1614426617

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#963](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f641983) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/f622aca8a453000874d6885654ff3029d1e38fc8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f622aca) will **increase** coverage by `0.23%`.
   > The diff coverage is `8.75%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #963      +/-   ##
   ============================================
   + Coverage     53.22%   53.45%   +0.23%     
   + Complexity     2507     2492      -15     
   ============================================
     Files           376      367       -9     
     Lines         20535    18426    -2109     
     Branches       1758     1769      +11     
   ============================================
   - Hits          10930     9850    -1080     
   + Misses         8920     7967     -953     
   + Partials        685      609      -76     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/uniffle/common/config/RssConf.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9jb25maWcvUnNzQ29uZi5qYXZh) | `33.53% <0.00%> (-0.21%)` | :arrow_down: |
   | [...he/uniffle/common/web/resource/MetricResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi93ZWIvcmVzb3VyY2UvTWV0cmljUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../common/web/resource/PrometheusMetricResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi93ZWIvcmVzb3VyY2UvUHJvbWV0aGV1c01ldHJpY1Jlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../uniffle/coordinator/web/resource/APIResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL0FQSVJlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...niffle/coordinator/web/resource/AdminResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL0FkbWluUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [.../coordinator/web/resource/ApplicationResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL0FwcGxpY2F0aW9uUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...inator/web/resource/CoordinatorServerResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL0Nvb3JkaW5hdG9yU2VydmVyUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...iffle/coordinator/web/resource/ServerResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL1NlcnZlclJlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...g/apache/uniffle/coordinator/web/vo/AppInfoVO.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3ZvL0FwcEluZm9WTy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../uniffle/coordinator/web/vo/CoordinatorConfVO.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3ZvL0Nvb3JkaW5hdG9yQ29uZlZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [6 more](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/963/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1617425985

   https://docs.google.com/document/d/10IEbbo_xQS-GHy0ezRcm9mT4Fv9hqghDsXivDpK1kas/edit?usp=sharing @jerqi @advancedxy @zuston 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1663496288

   > > > Do we must deploy dashboard as a single process? Could we deploy it by exists jetty server that in coordinator？
   > > 
   > > 
   > > Users can choose whether to start the dashboard module, which cannot be implemented without it
   > 
   > Why do users not use dashboard? What are the possible reasons? We need to deploy one more process, and we need to set the configuration for it, and we also need to consider how to deploy it on kubernetes. And in the future, we need to do permission check on both the coordinator and the dashboard.
   
   If we do some slow analysis operations in the dashboard, it will influence the coordinator if dashboard is deployed in the same process as the coordinator. It's ok to deploy them in two processes.
   
   It's ok if users want to deploy them in one process. You provide an option to support the feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1644936608

   > Should we the default configuration file to the directory `conf`? Should we add some documents to explain how to use dashboard. We can add the document in the next pr surely.
   
   Ok, I'll correct it right away


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 closed pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 closed pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page
URL: https://github.com/apache/incubator-uniffle/pull/963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1657464255

   > Do we must deploy dashboard as a single process? Could we deploy it by exists jetty server that in coordinator？
   
   Users can choose whether to start the dashboard module, which cannot be implemented without it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1648855045

   Do we must deploy dashboard as a single process? Could we deploy it by exists jetty server that in coordinator？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on code in PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#discussion_r1270187967


##########
dashboard/pom.xml:
##########
@@ -0,0 +1,96 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <artifactId>uniffle-parent</artifactId>
+    <groupId>org.apache.uniffle</groupId>
+    <version>0.8.0-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>dashboard</artifactId>
+  <name>Apache Uniffle Dashboard</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.uniffle</groupId>
+      <artifactId>coordinator</artifactId>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>com.github.eirslett</groupId>
+        <artifactId>frontend-maven-plugin</artifactId>
+        <version>1.12.1</version>
+        <executions>
+          <execution>
+            <id>install node and npm</id>
+            <goals>
+              <goal>install-node-and-npm</goal>
+            </goals>
+            <phase>generate-resources</phase>
+            <configuration>
+              <nodeVersion>v20.2.0</nodeVersion>
+              <npmVersion>9.6.6</npmVersion>
+              <nodeDownloadRoot>https://nodejs.org/dist/</nodeDownloadRoot>
+            </configuration>
+          </execution>
+          <!-- 执行脚本，删除node_modules和package-lock.json -->

Review Comment:
   Could we use English comments?



##########
dashboard/pom.xml:
##########
@@ -0,0 +1,96 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <artifactId>uniffle-parent</artifactId>
+    <groupId>org.apache.uniffle</groupId>
+    <version>0.8.0-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>dashboard</artifactId>
+  <name>Apache Uniffle Dashboard</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.uniffle</groupId>
+      <artifactId>coordinator</artifactId>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>com.github.eirslett</groupId>
+        <artifactId>frontend-maven-plugin</artifactId>
+        <version>1.12.1</version>
+        <executions>
+          <execution>
+            <id>install node and npm</id>
+            <goals>
+              <goal>install-node-and-npm</goal>
+            </goals>
+            <phase>generate-resources</phase>
+            <configuration>
+              <nodeVersion>v20.2.0</nodeVersion>
+              <npmVersion>9.6.6</npmVersion>
+              <nodeDownloadRoot>https://nodejs.org/dist/</nodeDownloadRoot>
+            </configuration>
+          </execution>
+          <!-- 执行脚本，删除node_modules和package-lock.json -->
+          <execution>
+            <id>npm run clean</id>
+            <goals>
+              <goal>npm</goal>
+            </goals>
+            <phase>generate-resources</phase>
+            <configuration>
+              <arguments>run clean</arguments>
+            </configuration>
+          </execution>
+          <!-- npm install -->
+          <execution>
+            <id>npm install</id>
+            <goals>
+              <goal>npm</goal>
+            </goals>
+            <phase>generate-resources</phase>
+            <configuration>
+              <arguments>install</arguments>
+            </configuration>
+          </execution>
+          <!-- build 之后复制文件到 src/main/resource/static 下 -->

Review Comment:
   ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1612319622

   > the ci is failed and I believe we should solve jersey conflict first. Will review once the conflict is resolve
   
   OK, I'll do it this week


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1663508456

   > If we do some slow analysis operations in the dashboard, it will influence the coordinator if dashboard is deployed in the same process as the coordinator. It's ok to deploy them in two processes.
   > 
   > It's ok if users want to deploy them in one process. You can provide an option to support the feature.
   
   Deploying in the same process can also achieve this feature. Just add a switch for the following code
   https://github.com/apache/incubator-uniffle/blob/78a8115b989d68696e5d8f473b633f3cb034d692/dashboard/src/main/java/org/apache/uniffle/dashboard/web/JettyServerFront.java#L90-L92


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1633996419

   > @yl09099 Hi, why this PR is closed?
   
   I need to wait for them to resolve the Jersey conflict, I will temporarily close it, a few days I will submit new code, I will open again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960][Improvement] Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1604146324

   3. at present, the relevant functions have not been developed, but the framework is introduced and the relevant front and back end can call and display the page;
   4. After the PR: #864 merger is completed, I will continue to make changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1611636550

   Could you write a document like https://docs.google.com/document/d/1G0cOFVJbYLf2oX1fiadh7zi2M6DlEcjTQTh4kSkb0LA/edit#heading=h.kl0vgpq0nxcy?
   You should also give others authority to edit the document.
   If we have a document, it will be more convenient to discuss.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] zuston commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1612319712

   > Could you write a document like https://docs.google.com/document/d/1G0cOFVJbYLf2oX1fiadh7zi2M6DlEcjTQTh4kSkb0LA/edit#heading=h.kl0vgpq0nxcy? You should also give others authority to edit the document. If we have a document, it will be more convenient to discuss.
   
   +1 
   
   I think the following points should be paid attention to and attached into design doc.
   1. The dashboard project code structure
   2. The restful api communication process, including shuffle-server/coordinator/dashboard server and the deployment design
   3. Detailed screenshot about main pages
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#960] feat(dashboard): Uniffle needs to add a WebUI page [incubator-uniffle]

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng closed pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page
URL: https://github.com/apache/incubator-uniffle/pull/963


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on pull request #963: [#960][Feature] Uniffle needs to add a WebUI page

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1606511543

   > This is really nice, remind me of the old good web ui for baidu's DCE shuffle. I will review this later today.
   
   @yl09099 Hi, the ci is failed and I believe we should solve jersey conflict first. Will review once the conflict is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1620957879

   > > 
   > 
   > Document editing permission has been opened
   
   Some comments left.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1633561778

   @yl09099 Hi, why this PR is closed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960][Improvement] Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1604135379

   ![unifflecoor](https://github.com/apache/incubator-uniffle/assets/33595968/67b6e0b3-288f-4b63-a319-c0bfc65107ff)
   ![uniffleshuffle](https://github.com/apache/incubator-uniffle/assets/33595968/b3acb4a6-40d5-459e-873b-67221575484e)
   ![coorapp](https://github.com/apache/incubator-uniffle/assets/33595968/51b6d301-7f88-4462-bdcb-489fc80be54f)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960][Improvement] Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1604141865

   The following changes were made:
   1. VUE3+element plus was adopted to realize front-end related development;
   2, the backend introduced Jersey support RESTful interface, learning from PR: #864 related code, but #864 Jersey will throw an exception, which has been fixed here;
   3, at present, the relevant functions have not been developed, but the framework is introduced and the relevant front and back end can call and display the page;
   4. After the PR: #864 merger is completed, I will continue to make changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1617590315

   > https://docs.google.com/document/d/10IEbbo_xQS-GHy0ezRcm9mT4Fv9hqghDsXivDpK1kas/edit?usp=sharing @jerqi @advancedxy @zuston
   
   Could you give us the authority of edition?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1617979165

   > 
   
   Document editing permission has been opened


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1663488351

   > > Do we must deploy dashboard as a single process? Could we deploy it by exists jetty server that in coordinator？
   > 
   > Users can choose whether to start the dashboard module, which cannot be implemented without it
   
   Why do users not use dashboard? What are the possible reasons?
   We need to deploy one more process,  and we need to set the configuration for it, and we also need to consider how to deploy it on kubernetes.
   And in the future, we need to do permission check on both the coordinator and the dashboard.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] jerqi commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1644931972

   Should we the default configuration file to the directory `conf`? Should we add some documents to explain how to use dashboard. We can add the document in the next pr surely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

[GitHub] [incubator-uniffle] yl09099 commented on pull request #963: [#960] feat(dashboard): Uniffle needs to add a WebUI page

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #963:
URL: https://github.com/apache/incubator-uniffle/pull/963#issuecomment-1644923179

   @advancedxy @jerqi I have developed the first version, please help me review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org