You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Suman Karumuri <sk...@twitter.com> on 2013/12/11 21:34:15 UTC
Review Request 16192: Installing JQuery and bootstrap from bower
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a scheduler-isolated.sh script to run a scheduler locally to test the UI changes.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs
-----
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
examples/scheduler/scheduler-isolated.sh PRE-CREATION
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <ma...@apache.org>.
> On Dec. 26, 2013, 8:18 p.m., Bill Farner wrote:
> >
Thanks queued!
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30884
-----------------------------------------------------------
On Dec. 19, 2013, 7:30 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 7:30 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap.css/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/component.json PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/jquery.js PRE-CREATION
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30884
-----------------------------------------------------------
Ship it!
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment59126>
This is _perfect_
- Bill Farner
On Dec. 19, 2013, 7:30 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 7:30 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> 3rdparty/javascript/bower_components/bootstrap.css/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/README.md PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/.bower.json PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/component.json PRE-CREATION
> 3rdparty/javascript/bower_components/jquery/jquery.js PRE-CREATION
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 7:30 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Spoke with Brian regarding changing third_party in vagrant. He suggested that third_party was incorrectly named and it should be called snapshots or python_cache. He added that eventually, it should be replaced with local_cache in .pants.d.
He also suggested that I use the science and mesos convention of using 3rdparty for third party code instead of third_party. So, moved all the Javascript stuff into 3rdparty/javascript directory.
Will rename third_party directory used by vagrant into snapshots in a separate diff.
Repository: aurora
Description
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs (updated)
-----
3rdparty/javascript/bower_components/bootstrap.css/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/README.md PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/bower.json PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
3rdparty/javascript/bower_components/jquery/.bower.json PRE-CREATION
3rdparty/javascript/bower_components/jquery/component.json PRE-CREATION
3rdparty/javascript/bower_components/jquery/jquery.js PRE-CREATION
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30560
-----------------------------------------------------------
.gitignore
<https://reviews.apache.org/r/16192/#comment58524>
Looks like my advice was bad, third_party is used for other purposes, and should be gitignore'd:
$ grep -R third_party .
./.gitignore:third_party/
./examples/vagrant/provision-dev-environment.sh: mkdir -p third_party
./examples/vagrant/provision-dev-environment.sh: pushd third_party
./pants.ini:repos: ['third_party/']
It looks like it shouldn't be too hard to claim third_party for this use case, but the other uses should be moved.
- Bill Farner
On Dec. 17, 2013, 8:07 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 8:07 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> .gitignore bf8c4e506f692b2088aeaeccf1d2cb9ca051649f
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> third_party/javascript/bower_components/bootstrap.css/.bower.json PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/README.md PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/bower.json PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> third_party/javascript/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> third_party/javascript/bower_components/jquery/.bower.json PRE-CREATION
> third_party/javascript/bower_components/jquery/component.json PRE-CREATION
> third_party/javascript/bower_components/jquery/jquery.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
(Updated Dec. 17, 2013, 8:07 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Moved bower_components to third_party/javascript.
Updated documentation per feedback.
Repository: aurora
Description
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs (updated)
-----
.gitignore bf8c4e506f692b2088aeaeccf1d2cb9ca051649f
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
third_party/javascript/bower_components/bootstrap.css/.bower.json PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/README.md PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/bower.json PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
third_party/javascript/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
third_party/javascript/bower_components/jquery/.bower.json PRE-CREATION
third_party/javascript/bower_components/jquery/component.json PRE-CREATION
third_party/javascript/bower_components/jquery/jquery.js PRE-CREATION
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <su...@gmail.com>.
> On Dec. 14, 2013, 1:52 a.m., Bill Farner wrote:
> > It would be really nice to see the third-party sources placed in a directory that makes the ownership blindingly obvious (and sheds our namespacing). For example, third_party/javascript would be awesome. This will require some gradle spelunking, but i'm confident it's possible.
Will add a third_party/javascript dir and send out another review.
- Suman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30396
-----------------------------------------------------------
On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:12 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30396
-----------------------------------------------------------
It would be really nice to see the third-party sources placed in a directory that makes the ownership blindingly obvious (and sheds our namespacing). For example, third_party/javascript would be awesome. This will require some gradle spelunking, but i'm confident it's possible.
build.gradle
<https://reviews.apache.org/r/16192/#comment58176>
indenting is inconsnstent
build.gradle
<https://reviews.apache.org/r/16192/#comment58177>
single quotes are used elsewhere unless double quotes are needed for string interpolation — please match that convention.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58179>
1. please advise ./gradlew instead of gradle
2. in theory, the 'run' task should let you do this in one command, args being specified with ./gradlew run -PrunArgs='$CMD_LINE_ARGS'
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58178>
Do i _need_ to install bower? Please explain why one needs to do this, since most people will not need to.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58180>
This makes me extremely uncomfortable. I recognize that to some degree we are blindly executing others' code frequently, but something about encouraging execution of unverified and arbitrarily-changing shell code to be particularly nasty. Can you at least fix this at a sha and include a checksum that someone can verify?
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58184>
Is it possible to install into a directory within the repository, so as to avoid conflict with what's installed on people's machines?
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58183>
Okay, i've got bower installed...what should i do with it now?
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58181>
revert
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16192/#comment58185>
remove or assign
- Bill Farner
On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:12 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/#review30459
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/16192/#comment58273>
Fixed.
build.gradle
<https://reviews.apache.org/r/16192/#comment58274>
Changed parens to match convention.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58296>
Removed this section from here. Will move it to the rb with the local scheduler script.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58297>
Marked it optional and updated description.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58331>
Removed nvm as an install option.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58333>
installing from brew will fix this.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58332>
Added a few bower commands to get people started.
docs/developing-aurora-scheduler.md
<https://reviews.apache.org/r/16192/#comment58319>
done
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/16192/#comment58334>
removed.
- Suman Karumuri
On Dec. 14, 2013, 1:12 a.m., Suman Karumuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16192/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:12 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Now installing JQuery and bootstrap from bower.
>
> Addded docs on managing bower dependencies and installing bower.
>
> Added docs on running the isolated scheduler script.
>
> Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
>
>
> Diffs
> -----
>
> build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
> docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
> src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
> src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16192/diff/
>
>
> Testing
> -------
>
> Tested the UI using the isolated scheduler.
>
> gradle clean build.
>
>
> Thanks,
>
> Suman Karumuri
>
>
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <sk...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
(Updated Dec. 14, 2013, 1:12 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Moved scheduler-isolated.sh script into a separate review at https://reviews.apache.org/r/16267/
Repository: aurora
Description (updated)
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs (updated)
-----
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <sk...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
(Updated Dec. 11, 2013, 8:45 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fixed minor indent issue in doc, so the commands render correctly on github.
Repository: aurora
Description
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a scheduler-isolated.sh script to run a scheduler locally to test the UI changes.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs (updated)
-----
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
examples/scheduler/scheduler-isolated.sh PRE-CREATION
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri
Re: Review Request 16192: Installing JQuery and bootstrap from bower
Posted by Suman Karumuri <sk...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16192/
-----------------------------------------------------------
(Updated Dec. 11, 2013, 8:36 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
Description
-------
Now installing JQuery and bootstrap from bower.
Addded docs on managing bower dependencies and installing bower.
Added docs on running the isolated scheduler script.
Added a scheduler-isolated.sh script to run a scheduler locally to test the UI changes.
Added a manifest to scheduler jar target in build.gradle, so the generated jar can be used in java -jar option.
Diffs
-----
build.gradle c66afa8f9dba7f1e772c67aeb5316894f31036c9
docs/developing-aurora-scheduler.md 1beafdc6466d2f5bdd0f09ea253bc8963e552f03
examples/scheduler/scheduler-isolated.sh PRE-CREATION
src/main/java/com/twitter/aurora/scheduler/http/ServletModule.java 2922f35df683ef3673c5fd83e391d7aba95415a7
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/README.md PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap-responsive.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/css/bootstrap.min.css PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings-white.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/img/glyphicons-halflings.png PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/bootstrap.css/js/bootstrap.min.js PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/.bower.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/component.json PRE-CREATION
src/main/resources/com/twitter/aurora/scheduler/http/assets/js/libs/bower_components/jquery/jquery.js PRE-CREATION
Diff: https://reviews.apache.org/r/16192/diff/
Testing
-------
Tested the UI using the isolated scheduler.
gradle clean build.
Thanks,
Suman Karumuri