You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Trustin Lee (JIRA)" <ji...@apache.org> on 2005/05/09 14:26:04 UTC

[jira] Created: (DIRMINA-31) SSLFilter doesn't work if other IoFilters exist in the same filter chain

SSLFilter doesn't work if other IoFilters exist in the same filter chain
------------------------------------------------------------------------

         Key: DIRMINA-31
         URL: http://issues.apache.org/jira/browse/DIRMINA-31
     Project: Directory MINA
        Type: Bug
    Versions: 0.7    
    Reporter: Trustin Lee
 Assigned to: Trustin Lee 
     Fix For: 0.9


It seems like SSLFilter doesn't work if any other filters that transforms dataRead and dataWritten event exist in the same chain.  It is because of its use of session.write() method while handshaking.  It is working because I/O layer and Protocol layer are separated and SSLFilter was the only filter that transforms bytebuffers in I/O layer.  I think all filter method should have access to previous filter, and it will cause changes to IoFilter and ProtocolFilter interfaces.

Should we give up releasing 0.7 because of this API design flaw, or should we fix this and release as 0.7.1?


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DIRMINA-31) SSLFilter doesn't work if other IoFilters exist in the same filter chain

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-31?page=all ]
     
Trustin Lee closed DIRMINA-31:
------------------------------

    Resolution: Fixed

> SSLFilter doesn't work if other IoFilters exist in the same filter chain
> ------------------------------------------------------------------------
>
>          Key: DIRMINA-31
>          URL: http://issues.apache.org/jira/browse/DIRMINA-31
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.7.1

>
> It seems like SSLFilter doesn't work if any other filters that transforms dataRead and dataWritten event exist in the same chain.  It is because of its use of session.write() method while handshaking.  It is working because I/O layer and Protocol layer are separated and SSLFilter was the only filter that transforms bytebuffers in I/O layer.  I think all filter method should have access to previous filter, and it will cause changes to IoFilter and ProtocolFilter interfaces.
> Should we give up releasing 0.7 because of this API design flaw, or should we fix this and release as 0.7.1?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (DIRMINA-31) SSLFilter doesn't work if other IoFilters exist in the same filter chain

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-31?page=all ]
     
Trustin Lee reopened DIRMINA-31:
--------------------------------


Mistakenly makred as 'won't fix'

> SSLFilter doesn't work if other IoFilters exist in the same filter chain
> ------------------------------------------------------------------------
>
>          Key: DIRMINA-31
>          URL: http://issues.apache.org/jira/browse/DIRMINA-31
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.7.1

>
> It seems like SSLFilter doesn't work if any other filters that transforms dataRead and dataWritten event exist in the same chain.  It is because of its use of session.write() method while handshaking.  It is working because I/O layer and Protocol layer are separated and SSLFilter was the only filter that transforms bytebuffers in I/O layer.  I think all filter method should have access to previous filter, and it will cause changes to IoFilter and ProtocolFilter interfaces.
> Should we give up releasing 0.7 because of this API design flaw, or should we fix this and release as 0.7.1?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DIRMINA-31) SSLFilter doesn't work if other IoFilters exist in the same filter chain

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-31?page=all ]
     
Trustin Lee closed DIRMINA-31:
------------------------------

    Resolution: Won't Fix

I fixed this issue by modifying internal implementation of NextFilter; I unified prevFilter and nextFilter into one.

> SSLFilter doesn't work if other IoFilters exist in the same filter chain
> ------------------------------------------------------------------------
>
>          Key: DIRMINA-31
>          URL: http://issues.apache.org/jira/browse/DIRMINA-31
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.7.1

>
> It seems like SSLFilter doesn't work if any other filters that transforms dataRead and dataWritten event exist in the same chain.  It is because of its use of session.write() method while handshaking.  It is working because I/O layer and Protocol layer are separated and SSLFilter was the only filter that transforms bytebuffers in I/O layer.  I think all filter method should have access to previous filter, and it will cause changes to IoFilter and ProtocolFilter interfaces.
> Should we give up releasing 0.7 because of this API design flaw, or should we fix this and release as 0.7.1?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-31) SSLFilter doesn't work if other IoFilters exist in the same filter chain

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-31?page=all ]

Trustin Lee updated DIRMINA-31:
-------------------------------

    Fix Version: 0.7.1
                     (was: 0.9)

> SSLFilter doesn't work if other IoFilters exist in the same filter chain
> ------------------------------------------------------------------------
>
>          Key: DIRMINA-31
>          URL: http://issues.apache.org/jira/browse/DIRMINA-31
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.7.1

>
> It seems like SSLFilter doesn't work if any other filters that transforms dataRead and dataWritten event exist in the same chain.  It is because of its use of session.write() method while handshaking.  It is working because I/O layer and Protocol layer are separated and SSLFilter was the only filter that transforms bytebuffers in I/O layer.  I think all filter method should have access to previous filter, and it will cause changes to IoFilter and ProtocolFilter interfaces.
> Should we give up releasing 0.7 because of this API design flaw, or should we fix this and release as 0.7.1?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira