You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apex.apache.org by th...@apache.org on 2016/01/14 06:00:33 UTC

incubator-apex-core git commit: APEXCORE-305 - Enable checkstyle violations logging to console during maven build

Repository: incubator-apex-core
Updated Branches:
  refs/heads/devel-3 3b6c252fe -> 59770d064


APEXCORE-305 - Enable checkstyle violations logging to console during maven build


Project: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/commit/59770d06
Tree: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/tree/59770d06
Diff: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/diff/59770d06

Branch: refs/heads/devel-3
Commit: 59770d0647bedbe81e794e3f3fd476e581c4339c
Parents: 3b6c252
Author: Vlad Rozov <v....@datatorrent.com>
Authored: Mon Jan 11 15:04:46 2016 -0800
Committer: Vlad Rozov <v....@datatorrent.com>
Committed: Mon Jan 11 15:14:01 2016 -0800

----------------------------------------------------------------------
 api/pom.xml          | 3 ---
 bufferserver/pom.xml | 4 +---
 common/pom.xml       | 3 ---
 engine/pom.xml       | 5 +++++
 pom.xml              | 6 ------
 5 files changed, 6 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/59770d06/api/pom.xml
----------------------------------------------------------------------
diff --git a/api/pom.xml b/api/pom.xml
index 4c8f00b..d5ea932 100644
--- a/api/pom.xml
+++ b/api/pom.xml
@@ -70,9 +70,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <configuration>
-          <logViolationsToConsole>true</logViolationsToConsole>
-        </configuration>
       </plugin>
     </plugins>
   </build>

http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/59770d06/bufferserver/pom.xml
----------------------------------------------------------------------
diff --git a/bufferserver/pom.xml b/bufferserver/pom.xml
index efc5b5e..aa79c0e 100644
--- a/bufferserver/pom.xml
+++ b/bufferserver/pom.xml
@@ -48,10 +48,8 @@
       </plugin>
       -->
       <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <configuration>
-          <consoleOutput>true</consoleOutput>
-        </configuration>
       </plugin>
     </plugins>
   </build>

http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/59770d06/common/pom.xml
----------------------------------------------------------------------
diff --git a/common/pom.xml b/common/pom.xml
index 5c2c98f..a749cea 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -55,9 +55,6 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
-        <configuration>
-          <logViolationsToConsole>true</logViolationsToConsole>
-        </configuration>
       </plugin>
     </plugins>
   </build>

http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/59770d06/engine/pom.xml
----------------------------------------------------------------------
diff --git a/engine/pom.xml b/engine/pom.xml
index 3e43184..2b70aa6 100644
--- a/engine/pom.xml
+++ b/engine/pom.xml
@@ -33,6 +33,10 @@
 
   <name>Apache Apex (incubating) Stream Processing Engine</name>
 
+  <properties>
+    <checkstyle.console>false</checkstyle.console>
+  </properties>
+
   <build>
     <finalName>${project.artifactId}</finalName>
     <plugins>
@@ -146,6 +150,7 @@
         <artifactId>maven-checkstyle-plugin</artifactId>
         <configuration>
           <maxAllowedViolations>3224</maxAllowedViolations>
+          <logViolationsToConsole>${checkstyle.console}</logViolationsToConsole>
         </configuration>
       </plugin>
       <plugin>

http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/59770d06/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 1972d37..164645c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -64,7 +64,6 @@
     <!-- do not change jetty version as later versions have problems with DefaultServlet -->
     <jetty.version>8.1.10.v20130312</jetty.version>
     <license.skip>true</license.skip>
-    <checkstyle.console>false</checkstyle.console>
     <postNoticeText>The initial developer of the original code is&#xA;DataTorrent, Inc. (http://www.datatorrent.com)&#xA;Copyright (c) 2012 - 2015. All Rights Reserved.</postNoticeText>
   </properties>
 
@@ -316,16 +315,11 @@
               <goals>
                 <goal>check</goal>
               </goals>
-              <configuration>
-                <failOnViolation>true</failOnViolation>
-                <logViolationsToConsole>${checkstyle.console}</logViolationsToConsole>
-              </configuration>
             </execution>
           </executions>
           <configuration>
             <configLocation>apex_checks.xml</configLocation>
             <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
-            <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
             <includeTestSourceDirectory>true</includeTestSourceDirectory>
           </configuration>
         </plugin>