[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1026: HDDS-3330. TestDeleteWithSlowFollower is still flaky.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #1026:
URL: https://github.com/apache/hadoop-ozone/pull/1026#discussion_r435987430



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestDeleteWithSlowFollower.java
##########
@@ -221,7 +223,9 @@ public void testDeleteKeyWithSlowFollower() throws Exception {
     }
     Assert.assertNotNull(follower);
     Assert.assertNotNull(leader);
-    // shutdown the slow follower
+    //ensure that the chosen follower is still a follower
+    Assert.assertTrue(ContainerTestHelper.isRatisFollower(follower, pipeline));

Review comment:
       There are no failures being induced till this check so, follower should still be a follower. I would prefer to fail the test in that case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org