You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/11/15 19:08:14 UTC

[GitHub] [celix] pnoltes commented on pull request #376: Eliminate unnecessary blocking and mutext from useServiceWithOptions.

pnoltes commented on pull request #376:
URL: https://github.com/apache/celix/pull/376#issuecomment-969227237


   > The only thing I have to do is to convince you that it will cause no problem ;)
   
   lol
   
   Very well written explanation.  What is new to me is the `synchronizes-with` part, but seeing this I think reading up to do.
   
   I now agree that the patch is correct. The only worry I have left, is whether relying on the use of mutexes/atomics in "downstream" functions make the code more complex to maintain. 
   
   But for this PR, I will approve it :)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org