[jira] Commented: (THRIFT-254) Add optional strict version support to binary protocols

["Michael Stockton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669802#action_12669802 ] 

Michael Stockton commented on THRIFT-254:
-----------------------------------------

I created a new patch that works with the changes made in THRIFT-248.  In order to compile my patch to the binary protocol extension, I added an include for stdint.h.  Depending on what's decided with THRIFT-298, I can change/remove the include statement.  Also, I noticed that a bunch of tests are failing because encode_binary and decode_binary are still being referenced. 

> Add optional strict version support to binary protocols
> -------------------------------------------------------
>
>                 Key: THRIFT-254
>                 URL: https://issues.apache.org/jira/browse/THRIFT-254
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Library (Ruby)
>            Reporter: Michael Stockton
>            Priority: Minor
>         Attachments: thrift-254-v2.patch, thrift-254.patch
>
>
> Several thrift libraries do not read a thrift version number in messages by default.  This can cause issues for a ruby user who interacts with thrift services written in other languages because the ruby library doesn't support an option to disable version validation.
> This patch does not change the default behavior, where thrift version numbers are expected, but it does add the option to disable version validation.
> For example:
> Thrift::BinaryProtocol.new(transport, strict_read=false, strict_write=true)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.