You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/04 08:55:44 UTC

[GitHub] [incubator-kyuubi] jiaoqingbo opened a new issue #2012: [Bug] kyuubi created an error directory, it should not be the ENGINE_EVENT_JSON_LOG_PATH but the SERVER_EVENT_JSON_LOG_PATH

jiaoqingbo opened a new issue #2012:
URL: https://github.com/apache/incubator-kyuubi/issues/2012


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   In EventLoggingService.scala ，when EventLoggerType is set to Json
   kyuubi created an error directory, it should not be the ENGINE_EVENT_JSON_LOG_PATH but the SERVER_EVENT_JSON_LOG_PATH
   
   1. 
   
   
   ### Affects Version(s)
   
   master
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed issue #2012: [Bug] EventLoggingService creates an incorrect directory

Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #2012:
URL: https://github.com/apache/incubator-kyuubi/issues/2012


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on issue #2012: [Bug] kyuubi created an error directory, it should not be the ENGINE_EVENT_JSON_LOG_PATH but the SERVER_EVENT_JSON_LOG_PATH

Posted by GitBox <gi...@apache.org>.
pan3793 commented on issue #2012:
URL: https://github.com/apache/incubator-kyuubi/issues/2012#issuecomment-1058978181


   Thanks for reporting this issue, have a glance of code, the name is confusing, as we has 2 classes share the name `EventLoggingService` in both `kyuubi-server` module and `kyuubi-spark-sql-engine` module, would you please also rename them to `KyuubiEventLoggingService`(for kyuubi-server) and `SparkEventLoggingService` (for kyuubi-spark-sql-engine)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] jiaoqingbo commented on issue #2012: [Bug] EventLoggingService creates an incorrect directory

Posted by GitBox <gi...@apache.org>.
jiaoqingbo commented on issue #2012:
URL: https://github.com/apache/incubator-kyuubi/issues/2012#issuecomment-1058987419


   > Thanks for reporting this issue, have a glance of code, the name is confusing, as we has 2 classes share the name `EventLoggingService` in both `kyuubi-server` module and `kyuubi-spark-sql-engine` module, would you please also rename them to `KyuubiEventLoggingService`(for kyuubi-server) and `SparkEventLoggingService` (for kyuubi-spark-sql-engine)?
   
   ok，I would rename them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org