You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Ludwig Magnusson <lu...@itcatapult.com> on 2011/10/09 15:15:11 UTC

[Fulcrum-parser] Update proposal

Hello team!
My company recently discovered that we need to be able to upload stream data in our web application. Commons-fileupload has support for this but fulcrum-upload does not.
I thought this would be a valuable addition to fulcrum upload and I think that I will be able to implement it this week. 
I also think this is a good oppertunity to release a new version of fulcrum-parent, including the new java version, and that fulcrum-upload could use it.

I intend to do the work this week and I would appreciate any comment or suggestion.
I also hope that any PMC member is willing to stage a release candidate once the work is complete.

/Ludwig

Re: [Fulcrum-parser] Update proposal

Posted by Ludwig Magnusson <lu...@itcatapult.com>.
After a little research this is what I figure needs to be done:

Extend the upload API, add method getItemIterator(request), that's the name 
of the method in Commons FileUpload.

Use the created method in DefaultParameterParser and add get-methods that 
return FileItemStream
http://commons.apache.org/fileupload/apidocs/org/apache/commons/fileupload/FileItemStream.html

So Upload needs a new release before parser and intake can use the new 
functionality.
/Ludwig


-----Ursprungligt meddelande----- 
From: Thomas Vandahl
Sent: Sunday, October 09, 2011 4:40 PM
To: Turbine Developers List
Subject: Re: [Fulcrum-parser] Update proposal

On 09.10.11 15:15, Ludwig Magnusson wrote:
> Hello team!
> My company recently discovered that we need to be able to upload stream 
> data in our web application. Commons-fileupload has support for this but 
> fulcrum-upload does not.
> I thought this would be a valuable addition to fulcrum upload and I think 
> that I will be able to implement it this week.

The implementations inside parser and intake are a bit
FileItem-specific, so this might need some API extensions in these
components, too (if that is possible at all). Other than that: good
suggestion, go ahead!

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: [Fulcrum-parser] Update proposal

Posted by Thomas Vandahl <tv...@apache.org>.
On 09.10.11 15:15, Ludwig Magnusson wrote:
> Hello team!
> My company recently discovered that we need to be able to upload stream data in our web application. Commons-fileupload has support for this but fulcrum-upload does not.
> I thought this would be a valuable addition to fulcrum upload and I think that I will be able to implement it this week. 

The implementations inside parser and intake are a bit
FileItem-specific, so this might need some API extensions in these
components, too (if that is possible at all). Other than that: good
suggestion, go ahead!

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: [Fulcrum-parser] Update proposal

Posted by Ludwig Magnusson <lu...@itcatapult.com>.
Sure, do it. I already had generification in mind for this upgrade...

-----Ursprungligt meddelande----- 
From: Thomas Vandahl
Sent: Sunday, October 09, 2011 4:52 PM
To: Turbine Developers List
Subject: Re: [Fulcrum-parser] Update proposal

On 09.10.11 15:15, Ludwig Magnusson wrote:
> I intend to do the work this week and I would appreciate any comment or 
> suggestion.
> I also hope that any PMC member is willing to stage a release candidate 
> once the work is complete.

Ludwig, I just have some modifications regarding generification for
fulcrum-upload and fulcrum-parser laying around. Not a big issue. Do you
want me to commit them before you start your work?

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: [Fulcrum-parser] Update proposal

Posted by Thomas Vandahl <tv...@apache.org>.
On 09.10.11 15:15, Ludwig Magnusson wrote:
> I intend to do the work this week and I would appreciate any comment or suggestion.
> I also hope that any PMC member is willing to stage a release candidate once the work is complete.

Ludwig, I just have some modifications regarding generification for
fulcrum-upload and fulcrum-parser laying around. Not a big issue. Do you
want me to commit them before you start your work?

Bye, Thomas.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update proposal

Posted by Ludwig Magnusson <lu...@itcatapult.com>.
Hi Siegfried.
Any possibility of an RC this week? =)
Or are there any more changes that needs to be done?
/Ludwig


From: Siegfried Goeschl
Sent: Sunday, October 09, 2011 7:27 PM
To: Turbine Developers List
Subject: Re: Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update 
proposal

I will take care of the parent pom release ....



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update proposal

Posted by Siegfried Goeschl <si...@it20one.at>.
Hi folks,

I think JDK 1.6 is the way to go since everything else is beyond EOL - I 
will take care of the parent pom release ....

Cheers,

Siegfried Goeschl

On 09.10.11 16:43, Thomas Vandahl wrote:
> On 09.10.11 15:15, Ludwig Magnusson wrote:
>> I also think this is a good oppertunity to release a new version of fulcrum-parent, including the new java version, and that fulcrum-upload could use it.
> I'd suggest to update the apache parent POM to some recent version on
> this occasion. Would JDK 1.5/6 be a good default for future component
> releases?
>
> Bye, Thomas.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
> For additional commands, e-mail: dev-help@turbine.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Re: Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update proposal

Posted by Ludwig Magnusson <lu...@itcatapult.com>.
Yes update to the latest I say.

According to the vote we had among users earlier this year, java 1.6 is the 
choice.

There are some optimizations that can be made such as upgrading plugins.
I can check this tonight and commit.

/Ludwig

-----Ursprungligt meddelande----- 
From: Thomas Vandahl
Sent: Sunday, October 09, 2011 4:43 PM
To: Turbine Developers List
Subject: Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update proposal

On 09.10.11 15:15, Ludwig Magnusson wrote:
> I also think this is a good oppertunity to release a new version of 
> fulcrum-parent, including the new java version, and that fulcrum-upload 
> could use it.

I'd suggest to update the apache parent POM to some recent version on
this occasion. Would JDK 1.5/6 be a good default for future component
releases?

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org

Release fulcrum-parent 2, was:Re: [Fulcrum-parser] Update proposal

Posted by Thomas Vandahl <tv...@apache.org>.
On 09.10.11 15:15, Ludwig Magnusson wrote:
> I also think this is a good oppertunity to release a new version of fulcrum-parent, including the new java version, and that fulcrum-upload could use it.

I'd suggest to update the apache parent POM to some recent version on
this occasion. Would JDK 1.5/6 be a good default for future component
releases?

Bye, Thomas.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@turbine.apache.org
For additional commands, e-mail: dev-help@turbine.apache.org