You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2012/11/12 15:02:04 UTC

svn commit: r1408291 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

Author: cmpilato
Date: Mon Nov 12 14:02:03 2012
New Revision: 1408291

URL: http://svn.apache.org/viewvc?rev=1408291&view=rev
Log:
Fix a pool lifetime problem and related SEGFAULTs.

* subversion/libsvn_ra_serf/update.c
  (handle_propchange_only, handle_local_content): Don't call
    maybe_close_dir_chain() at this sites -- seems to cause a pool
    lifetime problem.

Found by: philipm, ivan

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/update.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1408291&r1=1408290&r2=1408291&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/update.c Mon Nov 12 14:02:03 2012
@@ -1264,7 +1264,6 @@ handle_propchange_only(report_info_t *in
   svn_pool_destroy(info->pool);
 
   info->dir->ref_count--;
-  SVN_ERR(maybe_close_dir_chain(info->dir));
 
   return SVN_NO_ERROR;
 }
@@ -1289,7 +1288,6 @@ handle_local_content(report_info_t *info
   svn_pool_destroy(info->pool);
 
   info->dir->ref_count--;
-  SVN_ERR(maybe_close_dir_chain(info->dir));
 
   return SVN_NO_ERROR;
 }