You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "juliuszsompolski (via GitHub)" <gi...@apache.org> on 2023/07/25 11:41:51 UTC
[GitHub] [spark] juliuszsompolski opened a new pull request, #42150: [SPARK-33325][CONNECT] Validate that user provided sessionId is an UUID
juliuszsompolski opened a new pull request, #42150:
URL: https://github.com/apache/spark/pull/42150
### What changes were proposed in this pull request?
We want to validate that user provided sessionId is an UUID. Existing Spark Connect python and scala clients already do that, we would like to depend on it being in this format moving forward, just like we already validate that operatoinId is an UUID.
### Why are the changes needed?
Validate what's already assumed.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #42150: [SPARK-44425][CONNECT] Validate that user provided sessionId is an UUID
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #42150: [SPARK-44425][CONNECT] Validate that user provided sessionId is an UUID
URL: https://github.com/apache/spark/pull/42150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on pull request #42150: [SPARK-33325][CONNECT] Validate that user provided sessionId is an UUID
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on PR #42150:
URL: https://github.com/apache/spark/pull/42150#issuecomment-1653994564
@hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42150: [SPARK-44425][CONNECT] Validate that user provided sessionId is an UUID
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42150:
URL: https://github.com/apache/spark/pull/42150#issuecomment-1654684754
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on pull request #42150: [SPARK-33325][CONNECT] Validate that user provided sessionId is an UUID
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on PR #42150:
URL: https://github.com/apache/spark/pull/42150#issuecomment-1650132917
https://github.com/apache/spark/pull/42150/checks?check_run_id=15326399176 seems killed. Retrigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on pull request #42150: [SPARK-33325][CONNECT] Validate that user provided sessionId is an UUID
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on PR #42150:
URL: https://github.com/apache/spark/pull/42150#issuecomment-1651454144
https://github.com/apache/spark/pull/42150/checks?check_run_id=15332169713 pyspark testing was broken yesterday. Maybe working now? Retrigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org