You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2015/07/25 11:07:25 UTC
Re: svn commit: r1692600 -
/ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
Hi Jinghai,
I like to put the Jira issue title and description (summarised when necessaty) in commit comments, it clarifies things at 1st glance
Here for instance
----
"Screen with pagination on tables lead to multiple db entries when submitting"
Submitting a form on a Screen with larger list leads to double DB entries if pagination (next) is used.
From the cookbook it is known that pagination is automatically added if viewSize and viewIndex is set. Using this "auto pagination" functionalities
next button after submitting passes the submit parameters to the next call aswell.
Following steps do reproduce the problem:
* open up http://demo-stable-ofbiz.apache.org/catalog/control/EditProdCatalogCategories?prodCatalogId=TestCatalog&VIEW_SIZE_1=20&VIEW_INDEX_1=1
* Take default element numbers per page (20)
* Add a Category (and submit)
* Check DB for added entry
* Hit Next page link
* Check DB again for entry (there will be twice the same)
----
Don't be afraid if it's a bit long. If someone wants to look at this issue disconnected from Internet, they will still see what's about...
Hint: you can still edit the logs comments ;)
Thanks
Jacques
Le 25/07/2015 06:15, shijh@apache.org a écrit :
> Author: shijh
> Date: Sat Jul 25 04:15:33 2015
> New Revision: 1692600
>
> URL: http://svn.apache.org/r1692600
> Log:
> OFBIZ-6547.
>
> Applied patch (add paginate-target="EditProdCatalogCategories" to "EditProdCatalogCategories" form) and resolved this problem in trunk.
>
> Modified:
> ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
>
> Modified: ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml?rev=1692600&r1=1692599&r2=1692600&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml (original)
> +++ ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml Sat Jul 25 04:15:33 2015
> @@ -162,7 +162,7 @@ under the License.
> </field>
> </form>
> <form name="EditProdCatalogCategories" type="list" target="updateProductCategoryToProdCatalog" title="" list-name="prodCatalogCategories"
> - odd-row-style="alternate-row" default-table-style="basic-table">
> + odd-row-style="alternate-row" default-table-style="basic-table" paginate-target="EditProdCatalogCategories">
> <auto-fields-service service-name="updateProductCategoryToProdCatalog"/>
> <field name="prodCatalogId"><hidden/></field>
> <field name="productCategoryId" title="${uiLabelMap.ProductCategoryId}">
>
>
>
Re: svn commit: r1692600 -
/ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
OK, I took care of that, because the issue reported was not accurate but as you said Jinghai same than in OFBIZ-5634 and I mixed things a bit while
changing commits comments :/
Thanks
Jacques
Le 25/07/2015 11:07, Jacques Le Roux a écrit :
> Hi Jinghai,
>
> I like to put the Jira issue title and description (summarised when necessaty) in commit comments, it clarifies things at 1st glance
>
> Here for instance
> ----
> "Screen with pagination on tables lead to multiple db entries when submitting"
>
> Submitting a form on a Screen with larger list leads to double DB entries if pagination (next) is used.
>
> From the cookbook it is known that pagination is automatically added if viewSize and viewIndex is set. Using this "auto pagination" functionalities
> next button after submitting passes the submit parameters to the next call aswell.
>
> Following steps do reproduce the problem:
> * open up http://demo-stable-ofbiz.apache.org/catalog/control/EditProdCatalogCategories?prodCatalogId=TestCatalog&VIEW_SIZE_1=20&VIEW_INDEX_1=1
> * Take default element numbers per page (20)
> * Add a Category (and submit)
> * Check DB for added entry
> * Hit Next page link
> * Check DB again for entry (there will be twice the same)
> ----
>
> Don't be afraid if it's a bit long. If someone wants to look at this issue disconnected from Internet, they will still see what's about...
>
> Hint: you can still edit the logs comments ;)
>
> Thanks
>
> Jacques
>
> Le 25/07/2015 06:15, shijh@apache.org a écrit :
>> Author: shijh
>> Date: Sat Jul 25 04:15:33 2015
>> New Revision: 1692600
>>
>> URL: http://svn.apache.org/r1692600
>> Log:
>> OFBIZ-6547.
>>
>> Applied patch (add paginate-target="EditProdCatalogCategories" to "EditProdCatalogCategories" form) and resolved this problem in trunk.
>>
>> Modified:
>> ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
>>
>> Modified: ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml?rev=1692600&r1=1692599&r2=1692600&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml (original)
>> +++ ofbiz/trunk/applications/product/widget/catalog/ProdCatalogForms.xml Sat Jul 25 04:15:33 2015
>> @@ -162,7 +162,7 @@ under the License.
>> </field>
>> </form>
>> <form name="EditProdCatalogCategories" type="list" target="updateProductCategoryToProdCatalog" title="" list-name="prodCatalogCategories"
>> - odd-row-style="alternate-row" default-table-style="basic-table">
>> + odd-row-style="alternate-row" default-table-style="basic-table" paginate-target="EditProdCatalogCategories">
>> <auto-fields-service service-name="updateProductCategoryToProdCatalog"/>
>> <field name="prodCatalogId"><hidden/></field>
>> <field name="productCategoryId" title="${uiLabelMap.ProductCategoryId}">
>>
>>
>>
>