You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ace.apache.org by "J.W. Janssen (JIRA)" <ji...@apache.org> on 2014/03/06 14:30:43 UTC
[jira] [Commented] (ACE-168) Check version validity before
publishing to targets
[ https://issues.apache.org/jira/browse/ACE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922494#comment-13922494 ]
J.W. Janssen commented on ACE-168:
----------------------------------
Closing this issue. Such a check would be a snapshot at *that* particular moment in time, but does not guarantee anything about the future. Therefore, such a check would give only false hope that things are correct...
> Check version validity before publishing to targets
> ---------------------------------------------------
>
> Key: ACE-168
> URL: https://issues.apache.org/jira/browse/ACE-168
> Project: ACE
> Issue Type: Improvement
> Components: Deployment
> Reporter: Bram de Kruijff
>
> There is no sanity checking on artifacts (at least url) before publishing versions to targets. Simple case is an artifact with an url that is not accessible. This will result in any target it is associated to recieving a new version, polling for the deploymentpackage and getting an error (DeploymentServlet catches the IOException) for ever and ever and ever.
> I think URL attributes should at least be validated at creation and some way to prevent this endless fail cycle on every thread that handles deployment package requests affecting all targets would be nice.
> typical auditlog sample:
> ama-1,1314117989738,421,1314119324121,3001,version,9.0.0?current=8.0.0,name,http://localhost:8080/deployment/ama-1/versions/9.0.0?current=8.0.0
> ama-1,1314117989738,422,1314119326080,3001,version,9.0.0?current=8.0.0,name,http://localhost:8080/deployment/ama-1/versions/9.0.0?current=8.0.0
> ama-1,1314117989738,423,1314119328103,3001,version,9.0.0?current=8.0.0,name,http://localhost:8080/deployment/ama-1/versions/9.0.0?current=8.0.0
> typical client log sample:
> [2011-08-23 19:16:20] ERROR: Error installing update [org.apache.felix.framework]
> org.osgi.service.deploymentadmin.DeploymentException: null
> org.apache.felix.log.LogException: org.osgi.service.deploymentadmin.DeploymentException: null
> at org.apache.felix.deploymentadmin.DeploymentPackageManifest.<init>(DeploymentPackageManifest.java:53)
> at org.apache.felix.deploymentadmin.AbstractDeploymentPackage.<init>(AbstractDeploymentPackage.java:96)
> at org.apache.felix.deploymentadmin.StreamDeploymentPackage.<init>(StreamDeploymentPackage.java:48)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:194)
> at org.apache.ace.deployment.deploymentadmin.DeploymentAdminDeployer.install(DeploymentAdminDeployer.java:51)
> at org.apache.ace.deployment.task.DeploymentTaskBase.installVersion(DeploymentTaskBase.java:75)
> at org.apache.ace.deployment.task.DeploymentUpdateTask.run(DeploymentUpdateTask.java:57)
> at org.apache.ace.scheduler.Executer.run(Executer.java:92)
> at java.util.TimerThread.mainLoop(Timer.java:512)
> at java.util.TimerThread.run(Timer.java:462)
--
This message was sent by Atlassian JIRA
(v6.2#6252)