You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/10/02 11:00:43 UTC

Re: [PR] Minor: Add comment explaining why verify benchmark results uses release mode [arrow-datafusion]

alamb commented on code in PR #7712:
URL: https://github.com/apache/arrow-datafusion/pull/7712#discussion_r1342547264


##########
.github/workflows/rust.yml:
##########
@@ -241,6 +241,7 @@ jobs:
       - name: Verify that benchmark queries return expected results
         run: |
           export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
+          # use release build for plan verificaton because debug build causes stack overflow

Review Comment:
   From https://github.com/apache/arrow-datafusion/issues/7709#issuecomment-1742050117 it appears that `round_trip_logical_plan_q21` fails for some reason. 
   
   I did not debug it further. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org