[GitHub] [ozone] umamaheswararao commented on a change in pull request #2069: HDDS-4883. Persist replicationIndex on datanode side

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r608007205



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java
##########
@@ -410,6 +410,11 @@ ContainerCommandResponseProto createContainer(
         ContainerProtos.ContainerType.KeyValueContainer;
     createRequest.setContainerType(containerType);
 
+    if (containerRequest.hasWriteChunk()) {

Review comment:
       I think we decided to pack the index from pipeline object but not from BlockID right?

##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws IOException{
       GenericTestUtils.assertExceptionContains("No enum constant", ex);
     }
   }
-
-

Review comment:
       Why this test removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org