Re: svn commit: r1516850 - /commons/sandbox/weaver/trunk/pom.xml

[sebb <se...@gmail.com>]

On 23 August 2013 14:57,  <mb...@apache.org> wrote:
> Author: mbenson
> Date: Fri Aug 23 13:57:11 2013
> New Revision: 1516850
>
> URL: http://svn.apache.org/r1516850
> Log:
> fix commons componentid and modify scmPubUrl accordingly; remove unnecessarily overridden plugin config; document maven.compile.* properties
>
> Modified:
>     commons/sandbox/weaver/trunk/pom.xml
>
> Modified: commons/sandbox/weaver/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/sandbox/weaver/trunk/pom.xml?rev=1516850&r1=1516849&r2=1516850&view=diff
> ==============================================================================
> --- commons/sandbox/weaver/trunk/pom.xml (original)
> +++ commons/sandbox/weaver/trunk/pom.xml Fri Aug 23 13:57:11 2013
> @@ -39,15 +39,22 @@ under the License.
>
>    <properties>
>      <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
> +
> +    <!-- these will be needed with the next parent or promotion to proper:
> +    <maven.compiler.source>1.6</maven.compiler.source>
> +    <maven.compiler.target>1.6</maven.compiler.target>
> +     -->
> +    <!-- these are current: -->

Might be safer to define both "compiler" and "compile" versions.
The obsolete ones can be dropped when the parent is updated, but
meanwhile any plugins that use the standard names will work as
expected.

Perhaps define as follows:

<maven.compiler.source>1.6</maven.compiler.source>
..
<maven.compile.source>${maven.compiler.source}</maven.compile.source>
..

>      <maven.compile.source>1.6</maven.compile.source>
>      <maven.compile.target>1.6</maven.compile.target>
> -    <commons.componentid>commons-weaver</commons.componentid>
> +
> +    <commons.componentid>weaver</commons.componentid>
>      <commons.release.version>1.0</commons.release.version>
>      <commons.rc.version>RC1</commons.rc.version>
>      <!--commons.jira.id>WEAVER</commons.jira.id>
>      <commons.jira.pid>666</commons.jira.pid-->
>      <asm.version>4.1</asm.version>
> -    <commons.scmPubUrl>https://svn.apache.org/repos/infra/websites/production/commons/content/sandbox/${commons.componentid}</commons.scmPubUrl>
> +    <commons.scmPubUrl>https://svn.apache.org/repos/infra/websites/production/commons/content/sandbox/commons-weaver</commons.scmPubUrl>
>    </properties>
>
>    <developers>
> @@ -145,40 +152,10 @@ under the License.
>        <plugins>
>          <plugin>
>            <groupId>org.apache.maven.plugins</groupId>
> -          <artifactId>maven-compiler-plugin</artifactId>
> -          <version>2.5.1</version>
> -          <configuration>
> -            <source>${maven.compile.source}</source>
> -            <target>${maven.compile.target}</target>
> -            <encoding>UTF-8</encoding>
> -          </configuration>
> -        </plugin>
> -        <plugin>
> -          <groupId>org.apache.maven.plugins</groupId>
> -          <artifactId>maven-surefire-plugin</artifactId>
> -          <version>2.15</version>
> -        </plugin>
> -        <plugin>
> -          <groupId>org.apache.maven.plugins</groupId>
> -          <artifactId>maven-surefire-report-plugin</artifactId>
> -          <version>2.15</version>
> -        </plugin>
> -        <plugin>
> -          <groupId>org.apache.maven.plugins</groupId>
> -          <artifactId>maven-source-plugin</artifactId>
> -          <version>2.2.1</version>
> -        </plugin>
> -        <plugin>
> -          <groupId>org.apache.maven.plugins</groupId>
>            <artifactId>maven-dependency-plugin</artifactId>
>            <version>2.6</version>
>          </plugin>
>          <plugin>
> -          <groupId>org.apache.maven.plugins</groupId>
> -          <artifactId>maven-antrun-plugin</artifactId>
> -          <version>1.7</version>
> -        </plugin>
> -        <plugin>
>            <groupId>org.codehaus.mojo</groupId>
>            <artifactId>buildhelper-maven-plugin</artifactId>
>            <version>1.7</version>
> @@ -234,12 +211,8 @@ under the License.
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-javadoc-plugin</artifactId>
>          <configuration>
> -          <linksource>true</linksource>
> -          <links>
> -            <link>http://docs.oracle.com/javase/6/docs/api/</link>
> -          </links>
>            <aggregate>true</aggregate>
> -          </configuration>
> +        </configuration>
>        </plugin>
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org