[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #448: GUACAOMLE-893: Fix regression in LDAP filter with null value

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #448: GUACAOMLE-893: Fix regression in LDAP filter with null value
URL: https://github.com/apache/guacamole-client/pull/448#discussion_r333143456
 
 

 ##########
 File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
 ##########
 @@ -141,16 +141,21 @@ public ExprNode generateQuery(ExprNode filter,
         // the given search filter
         AndNode searchFilter = new AndNode();
         searchFilter.addNode(filter);
-
-        // Include all attributes within OR clause if there are more than one
-        OrNode attributeFilter = new OrNode();
+        
+        // Add in attribute list
+        if (attributes.size() > 0) {
 
 Review comment:
   If we should be adding nothing in the case where there are no attributes, would it make more sense to simply `return filter` if no attributes are given?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services