[GitHub] [hadoop] bgaborg edited a comment on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same

[GitBox <gi...@apache.org>]

bgaborg edited a comment on issue #1857: HADOOP-16878. Copy command in FileUtil to LOG at warn level if the source and destination is the same
URL: https://github.com/apache/hadoop/pull/1857#issuecomment-591431634
 
 
   > * findbugs is rejecting this as two different Path types are being referred.
   > * I'd like an exception to be raised, as this is clearly an error. Or log @ error and return -1, I guess...whichever looks best on the CLI
   
   I'll throw an exception then instead of just logging.
   > * going to need a test, I'm afraid
   
   I can create a test where I expect the exception. Or 3 tests because it's a modification in 3 different places.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org