You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/04 17:21:00 UTC
[jira] [Work logged] (BEAM-3910) Support floating point values in
Go SDK
[ https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=87648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87648 ]
ASF GitHub Bot logged work on BEAM-3910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/18 17:20
Start Date: 04/Apr/18 17:20
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #4941: BEAM-3910: Add float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941#discussion_r179219346
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/v1/v1.proto
##########
@@ -46,6 +46,8 @@ message Type {
UINT32 = 10;
UINT64 = 11;
STRING = 12;
+ FLOAT32 = 13;
Review comment:
Yes, this got missed somehow when I had this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 87648)
Time Spent: 40m (was: 0.5h)
Remaining Estimate: 23h 20m (was: 23.5h)
> Support floating point values in Go SDK
> ---------------------------------------
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Bill Neubauer
> Assignee: Bill Neubauer
> Priority: Major
> Original Estimate: 24h
> Time Spent: 40m
> Remaining Estimate: 23h 20m
>
> The Go SDK supports all the integer types of the language, but does not support floats.
> My plan for coding is to use the same technique the gob package uses, which results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210] with rationale explained in https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)