You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/06/01 06:33:42 UTC

[GitHub] spark pull request #21469: [SPARK-24441][SS] Expose total size of states in ...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21469#discussion_r192308080
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -181,6 +182,12 @@ private[state] class HDFSBackedStateStoreProvider extends StateStoreProvider wit
         }
       }
     
    +  def getCustomMetricsForProvider(): Map[StateStoreCustomMetric, Long] = {
    --- End diff --
    
    tiny nit:
    
    ```scala
    def getCustomMetricsForProvider(): Map[StateStoreCustomMetric, Long] = synchronized {
      Map(metricProviderLoaderMapSize -> SizeEstimator.estimate(loadedMaps))
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org