You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Jason Fehr (Jira)" <ji...@apache.org> on 2023/05/25 15:30:00 UTC

[jira] [Updated] (IMPALA-12163) Shell RPC Duration Does Not Match Start/End Time

     [ https://issues.apache.org/jira/browse/IMPALA-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Fehr updated IMPALA-12163:
--------------------------------
    Description: 
In the ImpalaHS2Client class within the impala_client.py file, the rpc duration is calculated [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#LL1260-L1261].]  Then, the rpc end time is determined by calling datetime.now() [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#L1265].]  This leads to stdout and rpc file having different rpc end times.

The duration is calculated incorrectly [here|https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#LL1267C22-L1267C22].  It needs to be calculated by calling the "total_seconds()" function.

  was:
In the ImpalaHS2Client class within the impala_client.py file, the rpc duration is calculated [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#LL1260-L1261].]  Then, the rpc end time is determined by calling datetime.now() [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#L1265].]  This leads to the rpc end time not matching the duration.  It also leads to stdout and rpc file having different rpc end times.

Fix this issue by using the variable "end_time" instead of calling datetime.now() multiple times.


> Shell RPC Duration Does Not Match Start/End Time
> ------------------------------------------------
>
>                 Key: IMPALA-12163
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12163
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>            Reporter: Jason Fehr
>            Assignee: Jason Fehr
>            Priority: Minor
>              Labels: shell
>
> In the ImpalaHS2Client class within the impala_client.py file, the rpc duration is calculated [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#LL1260-L1261].]  Then, the rpc end time is determined by calling datetime.now() [here|[https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#L1265].]  This leads to stdout and rpc file having different rpc end times.
> The duration is calculated incorrectly [here|https://github.com/apache/impala/blob/57964c83d37bdd61ec08b738c56725940138ab7d/shell/impala_client.py#LL1267C22-L1267C22].  It needs to be calculated by calling the "total_seconds()" function.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org