[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #56: CASSANDRASC-61: Add Release Audit Tool (RAT) plugin to Sidecar

["frankgh (via GitHub)" <gi...@apache.org>]

frankgh commented on code in PR #56:
URL: https://github.com/apache/cassandra-sidecar/pull/56#discussion_r1247139069


##########
NOTICE.txt:
##########
@@ -4,3 +4,11 @@ Copyright 2023- The Apache Software Foundation
 This product includes software developed by The Apache Software
 Foundation (http://www.apache.org/).
 
+

Review Comment:
   @michaelsembwever I think we don't need to add anything to NOTICE.txt after reviewing the link you sent, as well as what we do for Apache Cassandra. In fact, Cassandra has logback dependencies, but since they are not _bundled_, we don't need to add it to the notice.
   
   From Cassandra's `build.xml`:
   ```
             <dependency groupId="ch.qos.logback" artifactId="logback-core" version="1.2.9"/>
             <dependency groupId="ch.qos.logback" artifactId="logback-classic" version="1.2.9"/>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org