You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/05 12:38:33 UTC
[GitHub] [fineract] percyashu opened a new pull request #983: FINERACT-822 Enabling ErrorProne error checks
percyashu opened a new pull request #983:
URL: https://github.com/apache/fineract/pull/983
FINERACT-822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu commented on pull request #983: FINERACT-822 Enabling ErrorProne error checks
Posted by GitBox <gi...@apache.org>.
percyashu commented on pull request #983:
URL: https://github.com/apache/fineract/pull/983#issuecomment-639492600
@xurror @awasum @vorburger LGTY?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on a change in pull request #983: FINERACT-822 Enabling ErrorProne error checks
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #983:
URL: https://github.com/apache/fineract/pull/983#discussion_r436378823
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
##########
@@ -200,6 +199,7 @@ public static SavingsAccountTransactionEnumData transactionType(final SavingsAcc
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount");
break;
+ default:
Review comment:
@vorburger . That is Ok with me to review such PRs
I am looking into the points you raised wrt this merged PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #983: FINERACT-822 Enabling ErrorProne error checks
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #983:
URL: https://github.com/apache/fineract/pull/983#discussion_r436361965
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
##########
@@ -200,6 +199,7 @@ public static SavingsAccountTransactionEnumData transactionType(final SavingsAcc
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount");
break;
+ default:
Review comment:
@percyashu @awasum I disagree with this, this seems wrong to me - I've raised new #997 for it.
PS: I'm happy to help code review such PRs, if you would like me to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org