You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2021/11/23 00:13:13 UTC
[superset] 09/09: fix: sql lab crash caused by invalid template (#17133)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch 1.4
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3aa554b42271a1f70d0885b3735a220d0a782ae5
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Mon Oct 18 11:09:23 2021 -0700
fix: sql lab crash caused by invalid template (#17133)
(cherry picked from commit 96f44219615a287db267f9dc1c0073aa038e0ed0)
---
.../src/components/ErrorMessage/ParameterErrorMessage.tsx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx b/superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx
index 666ad32..739cfa7 100644
--- a/superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx
+++ b/superset-frontend/src/components/ErrorMessage/ParameterErrorMessage.tsx
@@ -56,7 +56,7 @@ function ParameterErrorMessage({
source = 'sqllab',
subtitle,
}: ErrorMessageComponentProps<ParameterErrorExtra>) {
- const { extra, level, message } = error;
+ const { extra = { issue_codes: [] }, level, message } = error;
const triggerMessage = tn(
'This was triggered by:',
@@ -99,9 +99,10 @@ function ParameterErrorMessage({
)}
{triggerMessage}
<br />
- {extra.issue_codes
- .map<React.ReactNode>(issueCode => <IssueCode {...issueCode} />)
- .reduce((prev, curr) => [prev, <br />, curr])}
+ {extra.issue_codes.length > 0 &&
+ extra.issue_codes
+ .map<React.ReactNode>(issueCode => <IssueCode {...issueCode} />)
+ .reduce((prev, curr) => [prev, <br />, curr])}
</p>
</>
);