You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/02 03:13:45 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1793: feature: using GitHub action for CI

membphis commented on a change in pull request #1793:
URL: https://github.com/apache/incubator-apisix/pull/1793#discussion_r448724281



##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,63 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master

Review comment:
       we need to run the GitHub action for every PR. blow is better.
   
   ```yaml
   on:
     push:
       branches: [ master ]
     pull_request:
       branches: [ master ]
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org