You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 12:34:45 UTC

[GitHub] [doris] luozenglin opened a new pull request, #13743: [fix](join) fix incorrect result when using anti join with other join predicates

luozenglin opened a new pull request, #13743:
URL: https://github.com/apache/doris/pull/13743

   
   # Proposed changes
   
   Issue Number: close #13742
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] starocean999 commented on pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
starocean999 commented on PR #13743:
URL: https://github.com/apache/doris/pull/13743#issuecomment-1296471503

   pls add a test case for right anti join


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] luozenglin commented on pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #13743:
URL: https://github.com/apache/doris/pull/13743#issuecomment-1296700996

   > 
   
   I have added the regression case for the right anti join: #13815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yangzhg merged pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #13743:
URL: https://github.com/apache/doris/pull/13743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] starocean999 commented on pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
starocean999 commented on PR #13743:
URL: https://github.com/apache/doris/pull/13743#issuecomment-1296470611

   pls double check if right anti join has similar issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13743:
URL: https://github.com/apache/doris/pull/13743#issuecomment-1293786894

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 38.54 seconds
    load time: 564 seconds
    storage size: 17154655318 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028003208_clickbench_pr_34931.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] luozenglin commented on pull request #13743: [fix](join) fix incorrect result when using anti join with other join predicates

Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #13743:
URL: https://github.com/apache/doris/pull/13743#issuecomment-1296502087

   > pls add a test case for right anti join
   
   The right anti join has the same problem as the left anti join and is fixed in this pr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org