You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/09/25 02:34:36 UTC
Review Request 38744: Incorrect Hosts table filtering after
navigating back from Host Summary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38744/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-13235
https://issues.apache.org/jira/browse/AMBARI-13235
Repository: ambari
Description
-------
There are 2 problems related to host page sorting.
1. Host model index was incorectly overridden in the host detail view
2. Persisted host sorting info in brower local db got reset every time we visit host page.
This patch fix above 2 issues.
Diffs
-----
ambari-web/app/mappers/hosts_mapper.js ed9ef26
ambari-web/app/views/common/sort_view.js 7ed4c72
Diff: https://reviews.apache.org/r/38744/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
9124 tests complete (9 seconds)
95 tests pending
Thanks,
Richard Zang
Re: Review Request 38744: Incorrect Hosts table filtering after
navigating back from Host Summary
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38744/#review100506
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Sept. 25, 2015, 12:34 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38744/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 12:34 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-13235
> https://issues.apache.org/jira/browse/AMBARI-13235
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There are 2 problems related to host page sorting.
> 1. Host model index was incorectly overridden in the host detail view
> 2. Persisted host sorting info in brower local db got reset every time we visit host page.
>
> This patch fix above 2 issues.
>
>
> Diffs
> -----
>
> ambari-web/app/mappers/hosts_mapper.js ed9ef26
> ambari-web/app/views/common/sort_view.js 7ed4c72
>
> Diff: https://reviews.apache.org/r/38744/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster. All unit tests passed.
> 9124 tests complete (9 seconds)
> 95 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 38744: Incorrect Hosts table filtering after
navigating back from Host Summary
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38744/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 6:17 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-13235
https://issues.apache.org/jira/browse/AMBARI-13235
Repository: ambari
Description
-------
There are 2 problems related to host page sorting.
1. Host model index was incorectly overridden in the host detail view
2. Persisted host sorting info in brower local db got reset every time we visit host page.
This patch fix above 2 issues.
Diffs
-----
ambari-web/app/mappers/hosts_mapper.js ed9ef26
ambari-web/app/views/common/sort_view.js 7ed4c72
Diff: https://reviews.apache.org/r/38744/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
9124 tests complete (9 seconds)
95 tests pending
File Attachments (updated)
----------------
AMBARI-13235-fix1.patch
https://reviews.apache.org/media/uploaded/files/2015/09/25/07a946d6-54f0-46ba-9bb1-ff11e363b43e__AMBARI-13235-fix1.patch
Thanks,
Richard Zang
Re: Review Request 38744: Incorrect Hosts table filtering after
navigating back from Host Summary
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38744/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 6:15 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-13235
https://issues.apache.org/jira/browse/AMBARI-13235
Repository: ambari
Description
-------
There are 2 problems related to host page sorting.
1. Host model index was incorectly overridden in the host detail view
2. Persisted host sorting info in brower local db got reset every time we visit host page.
This patch fix above 2 issues.
Diffs
-----
ambari-web/app/mappers/hosts_mapper.js ed9ef26
ambari-web/app/views/common/sort_view.js 7ed4c72
Diff: https://reviews.apache.org/r/38744/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
9124 tests complete (9 seconds)
95 tests pending
File Attachments (updated)
----------------
AMBARI-13235-fix1.patch
https://reviews.apache.org/media/uploaded/files/2015/09/25/91c854f3-337b-456c-b0a5-49562233aebf__AMBARI-13235-fix1.patch
Thanks,
Richard Zang
Re: Review Request 38744: Incorrect Hosts table filtering after
navigating back from Host Summary
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38744/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 6:03 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-13235
https://issues.apache.org/jira/browse/AMBARI-13235
Repository: ambari
Description
-------
There are 2 problems related to host page sorting.
1. Host model index was incorectly overridden in the host detail view
2. Persisted host sorting info in brower local db got reset every time we visit host page.
This patch fix above 2 issues.
Diffs
-----
ambari-web/app/mappers/hosts_mapper.js ed9ef26
ambari-web/app/views/common/sort_view.js 7ed4c72
Diff: https://reviews.apache.org/r/38744/diff/
Testing
-------
Manually tested on live cluster. All unit tests passed.
9124 tests complete (9 seconds)
95 tests pending
File Attachments (updated)
----------------
AMBARI-13235-fix1.patch
https://reviews.apache.org/media/uploaded/files/2015/09/25/88589975-ebd1-4a44-846e-10f0f45ca92c__AMBARI-13235-fix1.patch
Thanks,
Richard Zang