You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/17 21:46:51 UTC

[GitHub] [airflow] codecov-io commented on issue #5126: [AIRFLOW-4342] Use @cached_property instead of re-implementing it each time

codecov-io commented on issue #5126: [AIRFLOW-4342] Use @cached_property instead of re-implementing it each time
URL: https://github.com/apache/airflow/pull/5126#issuecomment-484273651
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=h1) Report
   > Merging [#5126](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a511b4877b88c5154474309e3acd7a60706415c9?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/5126/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5126      +/-   ##
   ==========================================
   + Coverage   77.96%   77.96%   +<.01%     
   ==========================================
     Files         465      465              
     Lines       29816    29797      -19     
   ==========================================
   - Hits        23245    23231      -14     
   + Misses       6571     6566       -5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/utils/decorators.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kZWNvcmF0b3JzLnB5) | `85.41% <ø> (-2.52%)` | :arrow_down: |
   | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.5% <100%> (-0.07%)` | :arrow_down: |
   | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `32.87% <100%> (+1.29%)` | :arrow_up: |
   | [airflow/contrib/hooks/gcp\_vision\_hook.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF92aXNpb25faG9vay5weQ==) | `91.51% <100%> (ø)` | :arrow_up: |
   | [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/5126/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `92.42% <0%> (-0.18%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=footer). Last update [a511b48...396a11b](https://codecov.io/gh/apache/airflow/pull/5126?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services