You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Michael Cooper (Created) (JIRA)" <ji...@apache.org> on 2011/11/28 07:26:40 UTC
[jira] [Created] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
avrocat/avropipe to use stdin when no file specified
----------------------------------------------------
Key: AVRO-961
URL: https://issues.apache.org/jira/browse/AVRO-961
Project: Avro
Issue Type: Improvement
Components: c
Environment: Linux x86_64
avro-c 1.6.1
Reporter: Michael Cooper
Priority: Trivial
Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Douglas Creager (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-961:
---------------------------------
Attachment: (was: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch)
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Attachments: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch, avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Michael Cooper (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Cooper updated AVRO-961:
--------------------------------
Attachment: avrocat.patch
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Attachments: avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Michael Cooper (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169113#comment-13169113 ]
Michael Cooper commented on AVRO-961:
-------------------------------------
looks good to me.
Slight issue: There appears to be spaces instead of tabs in io.c:avro_writer_t_ and io.c:_avro_reader_file_t
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Attachments: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch, avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Douglas Creager (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-961:
---------------------------------
Attachment: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch
The previous patch won't work on Windows systems, since there isn't a /dev/stdin file to open. This patch updates the I/O reader classes to take in an already-open FILE pointer. This lets avrocat and avropipe pass in the stdin FILE pointer directly, which should work on just about every system.
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Attachments: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch, avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Michael Cooper (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Cooper updated AVRO-961:
--------------------------------
Affects Version/s: 1.6.1
Status: Patch Available (was: Open)
Here is a patch.
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Douglas Creager (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-961:
---------------------------------
Resolution: Fixed
Fix Version/s: 1.6.2
Status: Resolved (was: Patch Available)
Committed to SVN
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Fix For: 1.6.2
>
> Attachments: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch, avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-961) avrocat/avropipe to use stdin when no
file specified
Posted by "Douglas Creager (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Douglas Creager updated AVRO-961:
---------------------------------
Attachment: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch
Good catch! Thanks for that.
> avrocat/avropipe to use stdin when no file specified
> ----------------------------------------------------
>
> Key: AVRO-961
> URL: https://issues.apache.org/jira/browse/AVRO-961
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.1
> Environment: Linux x86_64
> avro-c 1.6.1
> Reporter: Michael Cooper
> Priority: Trivial
> Labels: avro, avrocat, avropipe, c
> Attachments: 0001-AVRO-961.-C-avrocat-pipe-use-stdin-when-no-file-is-s.patch, avrocat.patch
>
>
> Currently, when using avrocat or avropipe in a pipe, you have to specify /dev/stdin explicitly.
> It would be nice if it defaulted to /dev/stdin when no file was specified.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira