You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 18:49:34 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #14113: ARROW-17717: [R] Lintr error on CI
thisisnic opened a new pull request, #14113:
URL: https://github.com/apache/arrow/pull/14113
The new release of lintr has a new feature - giving a warning when code is commented out - which is causing the lintr-containing CI job to fail. We could have pinned to a previous version of lintr, but that seem like a useful feature & the lines of code which trigger it seem like reasonable exceptions, so I've just added a #nolint flag on each of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #14113: ARROW-17717: [R] Lintr error on CI
Posted by GitBox <gi...@apache.org>.
thisisnic merged PR #14113:
URL: https://github.com/apache/arrow/pull/14113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #14113: ARROW-17717: [R] Lintr error on CI
Posted by GitBox <gi...@apache.org>.
thisisnic commented on PR #14113:
URL: https://github.com/apache/arrow/pull/14113#issuecomment-1246420529
DuckDB failure will be unrelated to these changes. Wouldn't usually merge with a pending review but given this is such a trivial change and already has one approval, I'll merge this now so that people working on other PRs can rebase and not have failing CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14113: ARROW-17717: [R] Lintr error on CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14113:
URL: https://github.com/apache/arrow/pull/14113#issuecomment-1245840354
https://issues.apache.org/jira/browse/ARROW-17717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14113: ARROW-17717: [R] Lintr error on CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14113:
URL: https://github.com/apache/arrow/pull/14113#issuecomment-1245840365
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14113: ARROW-17717: [R] Lintr error on CI
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14113:
URL: https://github.com/apache/arrow/pull/14113#issuecomment-1247090791
Benchmark runs are scheduled for baseline = 3338d998df9ae2aa6b76333b67d28a2569d35898 and contender = 8ec29ce4803807a30ff07b0077d0def6b8861680. 8ec29ce4803807a30ff07b0077d0def6b8861680 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/46d35f1b9d824036bd393cdbc8899082...02a28df46a304ecd90f47d8c1a0e3233/)
[Failed :arrow_down:0.44% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/12052350633c45fe9b856fb40e93d18d...c7ee703e41544d3c9adbefa02fefffae/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6c8555f722874d37bd18751e27d47527...228b70c521ae40eb85ae34af64d590fe/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d8a26c7fbcd4402e8f12e85ee611aa84...0e29075ff0ec407d9aa6345a34aa49ce/)
Buildkite builds:
[Finished] [`8ec29ce4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1472)
[Finished] [`8ec29ce4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1488)
[Failed] [`8ec29ce4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1472)
[Finished] [`8ec29ce4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1485)
[Finished] [`3338d998` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1471)
[Failed] [`3338d998` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1487)
[Failed] [`3338d998` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1471)
[Finished] [`3338d998` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1484)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org