You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/02 03:57:47 UTC
[GitHub] [incubator-doris] zhangstar333 opened a new pull request #8614: [Vectorized] support string type cast to bitmap
zhangstar333 opened a new pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614
# Proposed changes
Issue Number: close #8613
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614#issuecomment-1086570952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614#issuecomment-1086641610
Why should we support converting bitmap to string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 commented on a change in pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
zhangstar333 commented on a change in pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614#discussion_r841029836
##########
File path: be/src/vec/functions/function_cast.h
##########
@@ -803,6 +804,56 @@ struct ConvertThroughParsing {
}
};
+//convert string to bitmap or hll type
+template <typename FromDataType, typename ToDataType, typename Name>
+struct ConvertToComplex {
+ static_assert(std::is_same_v<FromDataType, DataTypeString>,
+ "ConvertToComplex is only applicable for String or FixedString data types");
+
+ using ToFieldType = typename ToDataType::FieldType;
+ using ColVecTo = ColumnComplexType<ToFieldType>;
+
+ template <typename Additions = void*>
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 closed pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
zhangstar333 closed pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
HappenLee commented on pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614#issuecomment-1086670415
> Why should we support converting bitmap to string?
This is to be compatible with regression testing to not cause coredump. Now directly prohibiting bitmap, HLL cast to string, which is afraid of introducing new problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8614: [Vectorized] support string type cast to bitmap
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #8614:
URL: https://github.com/apache/incubator-doris/pull/8614#discussion_r841026973
##########
File path: be/src/vec/functions/function_cast.h
##########
@@ -803,6 +804,56 @@ struct ConvertThroughParsing {
}
};
+//convert string to bitmap or hll type
+template <typename FromDataType, typename ToDataType, typename Name>
+struct ConvertToComplex {
+ static_assert(std::is_same_v<FromDataType, DataTypeString>,
+ "ConvertToComplex is only applicable for String or FixedString data types");
+
+ using ToFieldType = typename ToDataType::FieldType;
+ using ColVecTo = ColumnComplexType<ToFieldType>;
+
+ template <typename Additions = void*>
Review comment:
remove the template `Additions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org