You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Manjula Kutty (JIRA)" <ji...@apache.org> on 2007/02/08 23:25:05 UTC

[jira] Created: (DERBY-2312) Remove unwanted prints generated by the test

Remove unwanted prints generated by the test
--------------------------------------------

                 Key: DERBY-2312
                 URL: https://issues.apache.org/jira/browse/DERBY-2312
             Project: Derby
          Issue Type: Sub-task
          Components: Test
    Affects Versions: 10.3.0.0
            Reporter: Manjula Kutty
         Assigned To: Manjula Kutty
            Priority: Minor
             Fix For: 10.3.0.0


Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477462 ] 

Andrew McIntyre commented on DERBY-2312:
----------------------------------------

Can you please sync up and generate a new patch for Sttest? I cannot apply this patch after the change for DERBY-2311.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manjula Kutty updated DERBY-2312:
---------------------------------

    Attachment: DERBY-2312_diff_ver2.txt

Attaching the diff file for Sttest.java.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew McIntyre resolved DERBY-2312.
------------------------------------

    Resolution: Fixed
    Derby Info:   (was: [Patch Available])

Committed _ver3 patch to trunk with revision 514024.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_diff_ver3.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manjula Kutty closed DERBY-2312.
--------------------------------


> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_diff_ver3.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477549 ] 

Manjula Kutty commented on DERBY-2312:
--------------------------------------

Me and Andrew accidently put some comments for this issue on DERBY-2313. So copying them here

Andrew : There are still a lot of whitespace diffs in the patch, and it appears that some printlns have been added, as well as some removed, although it does appear to have condensed the overall output. I'll assume this is intentional and commit this patch shortly unless I hear otherwise. 
[ Show ยป ] Andrew McIntyre [02/Mar/07 03:25 PM] There are still a lot of whitespace diffs in the patch, and it appears that some printlns have been added, as well as some removed, although it does appear to have condensed the overall output. I'll assume this is intentional and commit this patch shortly unless I hear otherwise. 


> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_diff_ver3.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477405 ] 

Andrew McIntyre commented on DERBY-2312:
----------------------------------------

Hi Manjula, could you sync up and check the current files and regenerate the patch for this if necessary. It appears that most (all?) of the changes for this patch were included in the DERBY-2311 submission.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manjula Kutty updated DERBY-2312:
---------------------------------

    Derby Info: [Patch Available]

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manjula Kutty updated DERBY-2312:
---------------------------------

    Attachment: DERBY-2312_diff.txt
                DERBY-2312_stat.txt

attaching patch which will remove unwanted prints from the sttest. The Datatypes.java has the fix to DERBY-2311 also. Don't know how to diffrentiate them..since I did other fixes on the same file before commit. Please let me know how you people are managing to do more than one fix on the same file. 

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manjula Kutty updated DERBY-2312:
---------------------------------

    Attachment: DERBY-2312_diff_ver3.txt

Attaching the new patch after fixing the merge conflict

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_diff_ver3.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477558 ] 

Manjula Kutty commented on DERBY-2312:
--------------------------------------

The new System.out.println s are intentional since I removed prints which will print after insert/update/delete of each row. Now the test will print only the total number of rows inserted/deleted/updated.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_diff_ver3.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477472 ] 

Andrew McIntyre commented on DERBY-2312:
----------------------------------------

Hi Manjula, the _ver2 patch has a merge marker in it:

+<<<<<<< .mine
+		Datatypes.Rn = rand;
+		// harder to actually delete rows when there are
+		// more connections, so repeat operation more often
+=======
 		//harder to actually delete rows when there are
 		//more connections, so repeat operation more often
+>>>>>>> .r513939

Please resolve this merge and post an updated patch. You can check for unresolved conflicts in your checkout by looking for files with 'C' status when running svn stat.

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_diff_ver2.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2312) Remove unwanted prints generated by the test

Posted by "Manjula Kutty (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477452 ] 

Manjula Kutty commented on DERBY-2312:
--------------------------------------

I synced up and looked into it. Looks like we need the Sttest.java also committed, since I moved some prints from the Datatypes.java to here. I can post another path with only the changes to Sttest.java. Please let me know

> Remove unwanted prints generated by the test
> --------------------------------------------
>
>                 Key: DERBY-2312
>                 URL: https://issues.apache.org/jira/browse/DERBY-2312
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2312_diff.txt, DERBY-2312_stat.txt
>
>
> Remove unwanted prints generated by the test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.