You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2019/02/05 07:34:57 UTC
[maven] branch master updated: [MNG-6571] forgot to put new
instance in cache
This is an automated email from the ASF dual-hosted git repository.
hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new 6bd8bb9 [MNG-6571] forgot to put new instance in cache
6bd8bb9 is described below
commit 6bd8bb9ba6515446e3699202104f01f98fea1e63
Author: Hervé Boutemy <hb...@apache.org>
AuthorDate: Tue Feb 5 08:34:55 2019 +0100
[MNG-6571] forgot to put new instance in cache
---
.../src/main/java/org/apache/maven/artifact/versioning/VersionRange.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
index 5d7b254..8045bec 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
@@ -241,6 +241,7 @@ public class VersionRange
{
List<Restriction> restrictions = Collections.emptyList();
cached = new VersionRange( new DefaultArtifactVersion( version ), restrictions );
+ CACHE.put( version, cached );
}
return cached;
}
Re: [maven] branch master updated: [MNG-6571] forgot to put new instance in cache
Posted by Hervé BOUTEMY <he...@free.fr>.
sorry
I'll revert this commit and improve the handling...
Regards,
Hervé
Le mercredi 6 février 2019, 03:36:37 CET Dan Tran a écrit :
> I am seeing test failure at the latest maven-core. is it a known issue?
>
> [INFO] Running org.apache.maven.artifact.versioning.VersionRangeTest[ERROR]
> Tests run: 8, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.006
> s <<< FAILURE! - in
> org.apache.maven.artifact.versioning.VersionRangeTest[ERROR]
> testIntersections(org.apache.maven.artifact.versioning.VersionRangeTest)
> Time elapsed: 0.004 s <<<
> FAILURE!junit.framework.AssertionFailedError: check number of
> restrictions expected:<1> but was:<0>
> at
> org.apache.maven.artifact.versioning.VersionRangeTest.testIntersections(Ver
> sionRangeTest.java:185) [ERROR]
> testRange(org.apache.maven.artifact.versioning.VersionRangeTest) Time
> elapsed: 0 s <<< FAILURE!junit.framework.AssertionFailedError: check
> number of restrictions expected:<1> but was:<0>
> at
> org.apache.maven.artifact.versioning.VersionRangeTest.testRange(VersionRang
> eTest.java:72)
> On Mon, Feb 4, 2019 at 11:34 PM <hb...@apache.org> wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > hboutemy pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/maven.git
> >
> > The following commit(s) were added to refs/heads/master by this push:
> > new 6bd8bb9 [MNG-6571] forgot to put new instance in cache
> >
> > 6bd8bb9 is described below
> >
> > commit 6bd8bb9ba6515446e3699202104f01f98fea1e63
> > Author: Hervé Boutemy <hb...@apache.org>
> > AuthorDate: Tue Feb 5 08:34:55 2019 +0100
> >
> > [MNG-6571] forgot to put new instance in cache
> >
> > ---
> >
> > .../src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> >
> > | 1 +
> >
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Versio
> > nRange.java
> > b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Versi
> > onRange.java index 5d7b254..8045bec 100644
> > ---
> > a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Versio
> > nRange.java +++
> > b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/Versio
> > nRange.java @@ -241,6 +241,7 @@ public class VersionRange
> >
> > {
> >
> > List<Restriction> restrictions = Collections.emptyList();
> > cached = new VersionRange( new DefaultArtifactVersion(
> >
> > version ), restrictions );
> > + CACHE.put( version, cached );
> >
> > }
> > return cached;
> >
> > }
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven] branch master updated: [MNG-6571] forgot to put new
instance in cache
Posted by Dan Tran <da...@gmail.com>.
I am seeing test failure at the latest maven-core. is it a known issue?
[INFO] Running org.apache.maven.artifact.versioning.VersionRangeTest[ERROR]
Tests run: 8, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.006
s <<< FAILURE! - in
org.apache.maven.artifact.versioning.VersionRangeTest[ERROR]
testIntersections(org.apache.maven.artifact.versioning.VersionRangeTest)
Time elapsed: 0.004 s <<<
FAILURE!junit.framework.AssertionFailedError: check number of
restrictions expected:<1> but was:<0>
at org.apache.maven.artifact.versioning.VersionRangeTest.testIntersections(VersionRangeTest.java:185)
[ERROR] testRange(org.apache.maven.artifact.versioning.VersionRangeTest)
Time elapsed: 0 s <<< FAILURE!junit.framework.AssertionFailedError:
check number of restrictions expected:<1> but was:<0>
at org.apache.maven.artifact.versioning.VersionRangeTest.testRange(VersionRangeTest.java:72)
On Mon, Feb 4, 2019 at 11:34 PM <hb...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> hboutemy pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/maven.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 6bd8bb9 [MNG-6571] forgot to put new instance in cache
> 6bd8bb9 is described below
>
> commit 6bd8bb9ba6515446e3699202104f01f98fea1e63
> Author: Hervé Boutemy <hb...@apache.org>
> AuthorDate: Tue Feb 5 08:34:55 2019 +0100
>
> [MNG-6571] forgot to put new instance in cache
> ---
> .../src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> index 5d7b254..8045bec 100644
> ---
> a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> +++
> b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java
> @@ -241,6 +241,7 @@ public class VersionRange
> {
> List<Restriction> restrictions = Collections.emptyList();
> cached = new VersionRange( new DefaultArtifactVersion(
> version ), restrictions );
> + CACHE.put( version, cached );
> }
> return cached;
> }
>
>