You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by fan du <fa...@intel.com> on 2016/03/21 09:16:32 UTC

Review Request 45094: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45094/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-4981
    https://issues.apache.org/jira/browse/MESOS-4981


Repository: mesos


Description
-------

This change will cover three cases:
1. Directly call {re}registerFramework
2. Through HTTP call
3. Through MesosSchedulerDriver

And don't overlap 'master/messages_register_framework' with
'master/messages_reregister_framework'.


Diffs
-----

  src/master/master.cpp e6290ea686ccf17813d6faeaf2f2012f79cf3b7f 

Diff: https://reviews.apache.org/r/45094/diff/


Testing
-------

I can use 'docker-no-executor-framework' to reproduce/verify the issue.

    "master/messages_register_framework": 1.0,
    "master/messages_reregister_framework": 0.0,
    "master/messages_unregister_framework": 1.0,


Thanks,

fan du