You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/04/11 23:23:11 UTC
Review Request 46051: Moving resource-related classes into a new
package
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46051/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
IDE-driven refactoring. No functional changes.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/Offers.java 4c232f6b5a223b7da484a16e21cadad4fc155e35
src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java 9c2dc0ba54bffa8b36d5bf5fe2f549934470087c
src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d
src/main/java/org/apache/aurora/scheduler/ResourceType.java b4efc8d5b3e85f7bee792ae994480cf09cfe7e31
src/main/java/org/apache/aurora/scheduler/Resources.java 4baf9dddb1d846b37f3ff6362ec15606a9de0259
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 1fe27a55acdf1fe89a8d9cff97ff261c2dd32e3a
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java e4279b16e4e5f5ad80604c38a0b68e3d0e3138eb
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e8eb0cabb47cdfab30d63d643be0b929b93a8c0
src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java e9ee049e51e72fcf670ff74db6c3a9f83ab5622d
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java fb7c7b202c3002a6be4165628ee419a104870ac9
src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 8cef410e39fd1e4a60c991dbf4bd122e95acde58
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 7d92843504ef3cf17db7c780fc488451600cd6ba
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java d3b79635ece02d630bbdb1b53c25c94c2fb9978d
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java c18836a33341d56569763d6bfe3213e49110a26d
src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java bf7c0840dceb2fe586692158dee4114d4def9c83
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0c467a65798c86efd9d0b60e5a53c5d5289fb54d
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 08eb6d6c722950f6bc75c97ce12380eca16e704d
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java c9e57ececc5981c92248fd9974cf31dd71dd33e1
src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java 49ced129f49e741dedfbf33aa334a7cd3f09d732
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 6564e82a1431a5194241389c63240ec3f4c4d275
src/test/java/org/apache/aurora/scheduler/ResourcesTest.java ea74842fb976fd0542d136316b77be1206b4a5f0
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java b1426bc43d728f6aeaa8440ceaf4eec913cdc1d2
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java ea876887f02472cc7b52e6c79ab3297d872b932f
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java b9f9f529d2ea765e89dd751057228631359a66e1
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 17101f101f2ec1e9be75622ad31c760f46edd8c8
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 4f5ac1519a3121cf59ea055adf00d5239951b769
src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 13f41e3fcd9919c1827b51eb51e9e3271c337b43
src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 155ece448741e2ec0844e8651a5bee17a1f22697
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java bb1b01e15b95621637171331e0c72aebb9d77425
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java aedeab3fb89ca88df5f37e14bbcf0a109dfecbe7
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 0698f78de65d394597f33addb6651c48cf227b94
src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java f6bbbb81c15e917a54f084cf62787d85fc14e547
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 6af1fffceb5cdc7406a67d608e4a01ebdf71a2d0
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java b5fd204081ee802768d4926973689b22e94c1ed2
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java c3240cd457fb6bffe6077a3ded17afea4c9f6234
Diff: https://reviews.apache.org/r/46051/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 46051: Moving resource-related classes into a new
package
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46051/#review128260
-----------------------------------------------------------
Ship it!
Master (0dd096d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 11, 2016, 9:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46051/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:23 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> IDE-driven refactoring. No functional changes.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 4c232f6b5a223b7da484a16e21cadad4fc155e35
> src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java 9c2dc0ba54bffa8b36d5bf5fe2f549934470087c
> src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d
> src/main/java/org/apache/aurora/scheduler/ResourceType.java b4efc8d5b3e85f7bee792ae994480cf09cfe7e31
> src/main/java/org/apache/aurora/scheduler/Resources.java 4baf9dddb1d846b37f3ff6362ec15606a9de0259
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 1fe27a55acdf1fe89a8d9cff97ff261c2dd32e3a
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java e4279b16e4e5f5ad80604c38a0b68e3d0e3138eb
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e8eb0cabb47cdfab30d63d643be0b929b93a8c0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java e9ee049e51e72fcf670ff74db6c3a9f83ab5622d
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java fb7c7b202c3002a6be4165628ee419a104870ac9
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 8cef410e39fd1e4a60c991dbf4bd122e95acde58
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 7d92843504ef3cf17db7c780fc488451600cd6ba
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java d3b79635ece02d630bbdb1b53c25c94c2fb9978d
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java c18836a33341d56569763d6bfe3213e49110a26d
> src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java bf7c0840dceb2fe586692158dee4114d4def9c83
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0c467a65798c86efd9d0b60e5a53c5d5289fb54d
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 08eb6d6c722950f6bc75c97ce12380eca16e704d
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java c9e57ececc5981c92248fd9974cf31dd71dd33e1
> src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java 49ced129f49e741dedfbf33aa334a7cd3f09d732
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 6564e82a1431a5194241389c63240ec3f4c4d275
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java ea74842fb976fd0542d136316b77be1206b4a5f0
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java b1426bc43d728f6aeaa8440ceaf4eec913cdc1d2
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java ea876887f02472cc7b52e6c79ab3297d872b932f
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java b9f9f529d2ea765e89dd751057228631359a66e1
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 17101f101f2ec1e9be75622ad31c760f46edd8c8
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 4f5ac1519a3121cf59ea055adf00d5239951b769
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 13f41e3fcd9919c1827b51eb51e9e3271c337b43
> src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 155ece448741e2ec0844e8651a5bee17a1f22697
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java bb1b01e15b95621637171331e0c72aebb9d77425
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java aedeab3fb89ca88df5f37e14bbcf0a109dfecbe7
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 0698f78de65d394597f33addb6651c48cf227b94
> src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java f6bbbb81c15e917a54f084cf62787d85fc14e547
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 6af1fffceb5cdc7406a67d608e4a01ebdf71a2d0
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java b5fd204081ee802768d4926973689b22e94c1ed2
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java c3240cd457fb6bffe6077a3ded17afea4c9f6234
>
> Diff: https://reviews.apache.org/r/46051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 46051: Moving resource-related classes into a new
package
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46051/#review128257
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 2:23 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46051/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 2:23 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> IDE-driven refactoring. No functional changes.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java 4c232f6b5a223b7da484a16e21cadad4fc155e35
> src/main/java/org/apache/aurora/scheduler/AcceptedOffer.java 9c2dc0ba54bffa8b36d5bf5fe2f549934470087c
> src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d
> src/main/java/org/apache/aurora/scheduler/ResourceType.java b4efc8d5b3e85f7bee792ae994480cf09cfe7e31
> src/main/java/org/apache/aurora/scheduler/Resources.java 4baf9dddb1d846b37f3ff6362ec15606a9de0259
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 1fe27a55acdf1fe89a8d9cff97ff261c2dd32e3a
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java e4279b16e4e5f5ad80604c38a0b68e3d0e3138eb
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e8eb0cabb47cdfab30d63d643be0b929b93a8c0
> src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java e9ee049e51e72fcf670ff74db6c3a9f83ab5622d
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java fb7c7b202c3002a6be4165628ee419a104870ac9
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 8cef410e39fd1e4a60c991dbf4bd122e95acde58
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java 7d92843504ef3cf17db7c780fc488451600cd6ba
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java d3b79635ece02d630bbdb1b53c25c94c2fb9978d
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java c18836a33341d56569763d6bfe3213e49110a26d
> src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java bf7c0840dceb2fe586692158dee4114d4def9c83
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0c467a65798c86efd9d0b60e5a53c5d5289fb54d
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 08eb6d6c722950f6bc75c97ce12380eca16e704d
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java c9e57ececc5981c92248fd9974cf31dd71dd33e1
> src/test/java/org/apache/aurora/scheduler/AcceptedOfferTest.java 49ced129f49e741dedfbf33aa334a7cd3f09d732
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 6564e82a1431a5194241389c63240ec3f4c4d275
> src/test/java/org/apache/aurora/scheduler/ResourcesTest.java ea74842fb976fd0542d136316b77be1206b4a5f0
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java b1426bc43d728f6aeaa8440ceaf4eec913cdc1d2
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java ea876887f02472cc7b52e6c79ab3297d872b932f
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java b9f9f529d2ea765e89dd751057228631359a66e1
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 17101f101f2ec1e9be75622ad31c760f46edd8c8
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 4f5ac1519a3121cf59ea055adf00d5239951b769
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 13f41e3fcd9919c1827b51eb51e9e3271c337b43
> src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java 155ece448741e2ec0844e8651a5bee17a1f22697
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java bb1b01e15b95621637171331e0c72aebb9d77425
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java aedeab3fb89ca88df5f37e14bbcf0a109dfecbe7
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 0698f78de65d394597f33addb6651c48cf227b94
> src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java f6bbbb81c15e917a54f084cf62787d85fc14e547
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 6af1fffceb5cdc7406a67d608e4a01ebdf71a2d0
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java b5fd204081ee802768d4926973689b22e94c1ed2
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java c3240cd457fb6bffe6077a3ded17afea4c9f6234
>
> Diff: https://reviews.apache.org/r/46051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>