You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "judovana (via GitHub)" <gi...@apache.org> on 2023/12/22 09:17:06 UTC
[PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
judovana opened a new pull request, #20:
URL: https://github.com/apache/maven-archetypes/pull/20
hi!
Similarly as in https://github.com/apache/maven-archetypes/pull/18 the jdk7 bytecode is no longr viable in jdk21 world, and no one should be using jdk7.
Thus - much more simple then https://github.com/apache/maven-archetypes/pull/18 - bulk bump of 1.7 maven compiler settings to 1.8
I can not swear that I had not missed any, but I did my best to not miss any.
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-78) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MARCHETYPES-XXX] SUMMARY`, where you replace `MARCHETYPES-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867544276
I see you have closed #22 , thank you. Can we reopen this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7 [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1868919965
will be reworked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #20: [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions
URL: https://github.com/apache/maven-archetypes/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867531387
The https://github.com/apache/maven-archetypes/pull/18 was focusing only onec archetypes component - the quickstasrt - I did ti first, as it was a bit more compelx then the others.
This one is handling all others archetypes components. The original jira was named properly "maven-archetype-quickstart ...." - https://issues.apache.org/jira/browse/MARCHETYPES-76
The scond one https://issues.apache.org/jira/browse/MARCHETYPES-78 is handling all others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867536234
> superseded by #22
Sorry it is not surpassed. It is doing revert of good thing and is mixing several parts together.
I think it would be better to propose https://github.com/apache/maven-archetypes/pull/22/commits/6141badd9d7d3c90e51cfe6ec414b6a7fb2b25f5 as standalone PR. Merge that. And then merge this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867891940
While I have no objection to selecting Java 8 by default instead of Java 7, I feel I need to keep repeating that Java 7 is not end of life. It is supported by and available from multiple vendors. Oracle != Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867534247
superseded by #22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] archetypes generates EOLed maven.compiler versions [maven-archetypes]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867474617
what is the difference between this jira and the previous one [MARCHETYPES-78](https://issues.apache.org/jira/browse/MARCHETYPES-78) #18 ?
imho too many tickets with the same scope, "archetypes generate EOLed maven.compiler versions" Previously You have changed it to Java 7 and renamed directories also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7 [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana commented on PR #20:
URL: https://github.com/apache/maven-archetypes/pull/20#issuecomment-1867906389
> While I have no objection to selecting Java 8 by default instead of Java 7, I feel I need to keep repeating that Java 7 is not end of life. It is supported by and available from multiple vendors. Oracle != Java.
I think the pointing part is support of openjdk - last maintainer of openjdk7 was azul, and they dropped it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7 [maven-archetypes]
Posted by "judovana (via GitHub)" <gi...@apache.org>.
judovana closed pull request #20: [MARCHETYPES-78] Set Java 8 as default Java version in archetype created projects instead of Java 7
URL: https://github.com/apache/maven-archetypes/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org