You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2015/04/04 05:48:45 UTC

Re: Review Request 31366: Patch for KAFKA-1461

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31366/
-----------------------------------------------------------

(Updated April 4, 2015, 3:48 a.m.)


Review request for kafka.


Bugs: KAFKA-1461
    https://issues.apache.org/jira/browse/KAFKA-1461


Repository: kafka


Description (updated)
-------

KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


Diffs (updated)
-----

  core/src/main/scala/kafka/server/AbstractFetcherThread.scala 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b 
  core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 96faa7b4ed7c9ba8a3f6f9f114bd94e19b3a7ac0 

Diff: https://reviews.apache.org/r/31366/diff/


Testing
-------


Thanks,

Sriharsha Chintalapani


Re: Review Request 31366: Patch for KAFKA-1461

Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31366/#review79205
-----------------------------------------------------------

Ship it!


LGTM, Jun do you want to take another look?

- Guozhang Wang


On April 7, 2015, 3:41 p.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31366/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 3:41 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1461
>     https://issues.apache.org/jira/browse/KAFKA-1461
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.
> 
> 
> KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.
> 
> 
> KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/AbstractFetcherThread.scala f178527048ea5dbc8c1fde81a5bac54a8e1634c6 
>   core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 2d84afa451277e3769368678fd8ea578a8a81774 
> 
> Diff: https://reviews.apache.org/r/31366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>


Re: Review Request 31366: Patch for KAFKA-1461

Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31366/
-----------------------------------------------------------

(Updated April 7, 2015, 3:41 p.m.)


Review request for kafka.


Bugs: KAFKA-1461
    https://issues.apache.org/jira/browse/KAFKA-1461


Repository: kafka


Description
-------

KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


KAFKA-1461. Replica fetcher thread does not implement any back-off behavior.


Diffs (updated)
-----

  core/src/main/scala/kafka/server/AbstractFetcherThread.scala f178527048ea5dbc8c1fde81a5bac54a8e1634c6 
  core/src/main/scala/kafka/server/ReplicaFetcherThread.scala 2d84afa451277e3769368678fd8ea578a8a81774 

Diff: https://reviews.apache.org/r/31366/diff/


Testing
-------


Thanks,

Sriharsha Chintalapani