You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/01/23 11:59:40 UTC
Review Request 55840: AMBARI-19674. Asset Manager import and
validation issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.
Bugs: AMBARI-19674
https://issues.apache.org/jira/browse/AMBARI-19674
Repository: ambari
Description
-------
separate api for reading asset is implemented and used. Also validation for assetName check is added
Diffs
-----
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java 238b002
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java 53b43f9
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 7596de0
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java d8bf9ff
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java df936a4
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java 0622971
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java 9fe2f9c
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java afdee9e
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 7787bda
contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js dcfba34
contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 9ad0494
contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 4674533
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js a04c66d
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1822a20
contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 3e87644
contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 3ae4bff
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs bc5201d
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 7a21af1
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 7a6005a
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 38d8eaf
Diff: https://reviews.apache.org/r/55840/diff/
Testing
-------
manual
Thanks,
Madhan Reddy
Re: Review Request 55840: AMBARI-19674. Asset Manager import and
validation issues
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/#review162618
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Jan. 23, 2017, 11:59 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55840/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:59 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19674
> https://issues.apache.org/jira/browse/AMBARI-19674
>
>
> Repository: ambari
>
>
> Description
> -------
>
> separate api for reading asset is implemented and used. Also validation for assetName check is added
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java 238b002
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java 53b43f9
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 7596de0
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java d8bf9ff
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java df936a4
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java 0622971
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java 9fe2f9c
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java afdee9e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 7787bda
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js dcfba34
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 9ad0494
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 4674533
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js a04c66d
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1822a20
> contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 3e87644
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 3ae4bff
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs bc5201d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 7a21af1
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 7a6005a
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 38d8eaf
>
> Diff: https://reviews.apache.org/r/55840/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Madhan Reddy
>
>
Re: Review Request 55840: AMBARI-19674. Asset Manager import and
validation issues
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55840/#review162622
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 23, 2017, 11:59 a.m., Madhan Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55840/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:59 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19674
> https://issues.apache.org/jira/browse/AMBARI-19674
>
>
> Repository: ambari
>
>
> Description
> -------
>
> separate api for reading asset is implemented and used. Also validation for assetName check is added
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java 238b002
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/HDFSFileUtils.java 53b43f9
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java 7596de0
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java d8bf9ff
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java df936a4
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java 0622971
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java 9fe2f9c
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java afdee9e
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java 7787bda
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js dcfba34
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 9ad0494
> contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 4674533
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js a04c66d
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1822a20
> contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 3e87644
> contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less d91eb3b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs 3ae4bff
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs bc5201d
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs 7a21af1
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 7a6005a
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 38d8eaf
>
> Diff: https://reviews.apache.org/r/55840/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Madhan Reddy
>
>