You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/14 09:29:39 UTC
[GitHub] [spark] martin-g commented on a change in pull request #35501: [SPARK-36793][K8S] Support write container stdout/stderr to file
martin-g commented on a change in pull request #35501:
URL: https://github.com/apache/spark/pull/35501#discussion_r805650037
##########
File path: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh
##########
@@ -107,4 +107,14 @@ case "$1" in
esac
# Execute the container CMD under tini for better hygiene
-exec /usr/bin/tini -s -- "${CMD[@]}"
+if [ -z "$K8S_SPARK_LOG_PATH" ]; then
Review comment:
The env var has been renamed to `SPARK_K8S_LOG_PATH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org