[GitHub] [airflow] feluelle commented on a change in pull request #7903: [dont-merge] Add property conn_name to dbapi_hook

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #7903: [dont-merge] Add property conn_name to dbapi_hook
URL: https://github.com/apache/airflow/pull/7903#discussion_r399325848
 
 

 ##########
 File path: airflow/hooks/dbapi_hook.py
 ##########
 @@ -61,10 +61,17 @@ def __init__(self, *args, **kwargs):
             raise AirflowException("conn_name_attr is not defined")
         elif len(args) == 1:
             setattr(self, self.conn_name_attr, args[0])
-        elif self.conn_name_attr not in kwargs:
-            setattr(self, self.conn_name_attr, self.default_conn_name)
-        else:
+        elif self.conn_name_attr in kwargs:
             setattr(self, self.conn_name_attr, kwargs[self.conn_name_attr])
+        else:
+            setattr(self, self.conn_name_attr, self.default_conn_name)
+
+    @property
+    def conn_name(self) -> str:
+        """
+        Get conn_name to avoid pylint no-member in subclass
 
 Review comment:
   We don't add production code only because a linter is unhappy!
   
   What it give us is that it..
   ```suggestion
           Get the name of the database connection attribute which identifies the connection.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services