[GitHub] [cloudstack] anuragaw edited a comment on issue #3720: VM stopped/crashing while Migration with Maintenance Mode (KVM)

[GitBox <gi...@apache.org>]

anuragaw edited a comment on issue #3720: VM stopped/crashing while Migration with Maintenance Mode (KVM)
URL: https://github.com/apache/cloudstack/issues/3720#issuecomment-559167950
 
 
   My 2 cents - adding forceMaintenance is really going to complicate code unnecessarily. Marking host to maintenance and migration jobs for VMs are separate background tasks. Putting a host into maintenance is not going to be a frequent operation inmho worth the code complexity.
   
   Perhaps sticking to the general theory - `If Migrations cannot be completed and host cannot be put to maintenance safely, we put the host to ErrorInMaintenance state`. At the same time we log/throw exception for informing the admins.
   
   Admins can put the VMs off or snapshot or whatever works best - then they can manually shutdown all VMs on a host as needed and retry maintenance transition. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services