You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/10 07:07:05 UTC
[GitHub] [iceberg] kbendick opened a new pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
kbendick opened a new pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520
This PR is trying to address this comment: [#3501 (comment)](https://github.com/apache/iceberg/pull/3501#discussion_r745401341)
It seems that checkstyle has not been running for some (or all) of the Java / Scala code outside of `java-ci.yml` due to `-Pquick=true`.
I had noticed and fixed a rogue checkstyle issue that made it in, but I thought it slipped in during the refactoring of tests as a one time thing.
@openinx suggested in this PR: [#3509](https://github.com/apache/iceberg/pull/3509) that we remove the path ignores in java-ci.yaml. But I think that would negate the work of splitting up the tests and the speed built up that we have seen from that.
Co-authored-by: huzheng <op...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-965778738
> @kbendick do we need to adjust the same thing in `hive-ci.yml`?
Yes we do. If I don't add that one today (a bit under the weather), feel free to do it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-964857295
The other reason things work presently in `java-ci.yml` is that we have two sections related to tests and checks.
We have the one used presently, equivalent to `core-tests`, and then the `build-checks` section.
I'm going to add `build-chcks` into the existing code so that nothing gets in that doesn't pass CI as it should, and then prioritize a top level workflow that orchestrates all of them so when one fails, they all fail.
```
core-tests:
runs-on: ubuntu-latest
strategy:
matrix:
jvm: [8, 11]
env:
SPARK_LOCAL_IP: localhost
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: ${{ matrix.jvm }}
- uses: actions/cache@v2
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' | cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- run: ./gradlew check -DsparkVersions= -DhiveVersions= -DflinkVersions= -Pquick=true -x javadoc
- uses: actions/upload-artifact@v2
if: failure()
with:
name: test logs
path: |
**/build/testlogs
build-checks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: 8
- run: ./gradlew build -x test -x javadoc -x integrationTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-965016136
@kbendick do we need to adjust the same thing in `hive-ci.yml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-968361801
@kbendick, I commented on the Spark PR. This should use the existing Java CI job instead of adding duplicate checks that will slow down Spark and Flink test builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3520: Build: Ensure checkstyle and all check run for Flink PRs
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3520:
URL: https://github.com/apache/iceberg/pull/3520#issuecomment-968364933
Closing since this was just fixed by #3509.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org